-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http object type #143
Closed
Closed
Http object type #143
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f62b005
WIP: http endpoints types
afek854 ca05ab0
add generated code
matthyx 746675d
WIP: added NetworkDirection
afek854 52c19dd
bump code generation script
matthyx fa4339b
WIP: Fixed generation script
afek854 f732160
WIP: Removed HTTPEndpoint deepcopy
afek854 29e5c27
WIP: Removed HTTPEndpoint from softwarecomposition client
afek854 d18f37f
WIP: Fixed generated files
afek854 b7247ee
WIP: Fixed types.go
afek854 55f2415
WIP: Removed NetworkDirection
afek854 b4af75f
WIP: Removed logs
afek854 475efb4
WIP: Move to string
afek854 b146246
WIP: Convert to string
afek854 92f49a3
WIP: Added consts
afek854 afd4787
WIP: Multiple header values
afek854 398f45b
WIP: Added Path & URL analyzing
afek854 247343c
WIP: removed debug logs
afek854 e74c136
WIP: Handle duplicates url's
afek854 2019ba4
WIP: Fixed typos & added benchmark tests
afek854 3baaf64
Added coverage & benchmark tests
afek854 0990541
WIP: Fixed bugs due tests
afek854 ee792eb
WIP: Added extra and tests
afek854 08d18d2
WIP: Added tests for extra
afek854 d8b79ec
WIP: Removed Extra field
afek854 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package consts | ||
|
|
||
| type NetworkDirection string | ||
|
|
||
| const ( | ||
| Inbound NetworkDirection = "inbound" | ||
| Outbound NetworkDirection = "outbound" | ||
| ) | ||
|
|
||
| type IsInternal string | ||
|
|
||
| const ( | ||
| True IsInternal = "true" | ||
| False IsInternal = "false" | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced we need to do this... this sounds non idiomatic Go to me - do you have some reference for this pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdym by it? I did it because I could not transfer bool value (The bug we talked about)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn, forgot about it. Still looking ugly 🫣