add gRPC to our API server #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthyx
force-pushed
the
grpc
branch
3 times, most recently
from
d19c701
to
91a015c
Compare
matthyx
commented
Aug 27, 2024
| @@ -129,5 +129,5 @@ type GrypeDocument struct { | |||
| IgnoredMatches []IgnoredMatch | |||
| Source *Source | |||
| Distro Distribution | |||
| Descriptor Descriptor | |||
| Descriptor_ Descriptor | |||
matthyx
commented
Aug 27, 2024
| @@ -52,10 +52,10 @@ type ScannedControlStatus struct { | |||
| type ScannedControlRule struct { | |||
| Name string | |||
| Status RuleStatus | |||
| ControlConfigurations map[string][]string | |||
| ControlConfigurations map[string]string | |||
There was a problem hiding this comment.
@slashben this one is causing unmarshaling issues for WorkloadConfigurationScan (continuous scanning)
for some reason the protobufs don't like the initial map so I thought I could change it like that
There was a problem hiding this comment.
though it should be allowed https://protobuf.dev/programming-guides/proto3/#maps
There was a problem hiding this comment.
I think I've found a workaround by delaying unmarshalling with json.RawMessage
matthyx
commented
Aug 27, 2024
| UserID int64 | ||
| GroupID int64 | ||
| MIMEType string | ||
| Size_ int64 |
matthyx
commented
Aug 27, 2024
| @@ -640,7 +584,7 @@ type SingleSeccompProfileSpec struct { | |||
| // Additional properties from OCI runtime spec | |||
|
|
|||
| // list of flags to use with seccomp(2) | |||
| Flags []*Flag | |||
| Flags []Flag | |||
matthyx
force-pushed
the
grpc
branch
2 times, most recently
from
68aec88
to
601bb90
Compare
|
Summary:
|
1 similar comment
|
Summary:
|
|
Summary:
|
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
|
Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.