Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging in recommender, updater, and target components #7294

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Refactor logging in recommender, updater, and target components #7294

wants to merge 16 commits into from
+57 −68

Conversation

omerap12
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

To align the logging with the best practices and guidelines established within the Kubernetes ecosystem.

Which issue(s) this PR fixes:

As part of #6905, I'm splitting this into multiple PRs rather than submitting a single large PR.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @omerap12. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2024
@adrianmoisey
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2024
@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2024
@adrianmoisey
Copy link
Member

Hey @jbartosik, can you approve this?
/assign jbartosik

@kwiesmueller
Copy link
Member

Cool to see structured logging is an option now!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2024
@omerap12 omerap12 force-pushed the logging-vpa-routines-updater-target branch from 89e5cab to 13b6d90 Compare September 25, 2024 08:11
@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2024
@voelzmo
Copy link
Contributor

voelzmo commented Oct 18, 2024

/unassign @jbartosik
/assign

@k8s-ci-robot k8s-ci-robot assigned voelzmo and unassigned jbartosik Oct 18, 2024
voelzmo
voelzmo suggested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@voelzmo voelzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through all the files!
A few small patches to add more context.

Also in this change: there's a few occasions of klog.Warningf, could you also take care of those, please? Thanks!

vertical-pod-autoscaler/pkg/recommender/model/types.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/target/controller_fetcher/controller_fetcher.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/target/controller_fetcher/controller_fetcher.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/updater/eviction/pods_eviction_restriction.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/updater/eviction/pods_eviction_restriction.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/updater/priority/priority_processor.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please ask for approval from voelzmo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@omerap12 @voelzmo
fixed typo
d3951fe 
Co-authored-by: Marco Voelz <[email protected]>
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2024
omerap12 and others added 8 commits October 18, 2024 15:33
@omerap12 @voelzmo
using klog.KRef
6530a78 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
using klog.KRef
a7d38df 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
using klog.KRef
38a44c5 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
using klog.KRef
a6780e3 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
using klog.KRef
1dc6b5d 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
using klog.KRef
e100ac1 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
using klog.KRef
8297255 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12
Use ErrorS
f37f0dc 
Signed-off-by: Omer Aplatony <[email protected]>
@omerap12 omerap12 force-pushed the logging-vpa-routines-updater-target branch from b28fd60 to f37f0dc Compare October 18, 2024 12:49
omerap12 and others added 2 commits October 18, 2024 15:50
@omerap12 @voelzmo
using klog.KRef
0e9193f 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12
Change signature
6b8beaf 
Signed-off-by: Omer Aplatony <[email protected]>
@omerap12
Copy link
Member Author

Thanks for going through all the files! A few small patches to add more context.

Also in this change: there's a few occasions of klog.Warningf, could you also take care of those, please? Thanks!

Thanks for your review!
Regarding klog.Warningf, there is no klog.WarningS so I'm converting all klog.Warningf to klog.V(0).InfoS is that ok? (please see here)

@omerap12
add vpa to func signature
c72781d 
Signed-off-by: Omer Aplatony <[email protected]>
@omerap12 omerap12 mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmoisey adrianmoisey adrianmoisey left review comments

@voelzmo voelzmo voelzmo requested changes

@krzysied krzysied Awaiting requested review from krzysied

@kwiesmueller kwiesmueller Awaiting requested review from kwiesmueller

Assignees

@adrianmoisey adrianmoisey

@voelzmo voelzmo

Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@omerap12 @k8s-ci-robot @adrianmoisey @kwiesmueller @voelzmo @jbartosik