Index migration ci test (#621)

* Add ci test to verify index migration

* Run shfmt

* Install krew 0.3.4

* Install to correct dir

* Set krew root properly

* Remove ls

* Remove unnecessary function

.github/workflows/ci.yml

@@ -60,6 +60,9 @@ jobs:
     - name: Run integration tests
       run: hack/run-integration-tests.sh
 
+    - name: Verify index migration from 0.3.x to 0.4.x
+      run: hack/verify-index-migration.sh
+
     - name: Create a new release
       if: contains(github.ref, 'tags')
       id: create_release

hack/verify-index-migration.sh

@@ -0,0 +1,105 @@
+#!/usr/bin/env bash
+
+# Copyright 2020 The Kubernetes Authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This script tests the automatic index migration which was added for
+# migrating krew 0.3.x to krew 0.4.x.
+#
+# TODO(ahmetb,corneliusweig,chriskim06) remove at/after krew 0.5.x when
+# index-migration is no longer supported.
+
+set -euo pipefail
+
+[[ -n "${DEBUG:-}" ]] && set -x
+
+SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+BINDIR="${SCRIPTDIR}/../out/bin"
+goos="$(go env GOOS)"
+goarch="$(go env GOARCH)"
+
+install_krew_0_3_4() {
+  krew_root="${1}"
+  temp_dir="$(mktemp -d)"
+  trap 'rm -rf "${temp_dir}"' RETURN
+  (
+    set -x
+    cd "${temp_dir}" &&
+      curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/download/v0.3.4/krew.{tar.gz,yaml}" &&
+      tar zxvf krew.tar.gz &&
+      KREW=./krew-"$(uname | tr '[:upper:]' '[:lower:]')_amd64" &&
+      env KREW_ROOT="${krew_root}" "$KREW" install --manifest=krew.yaml --archive=krew.tar.gz &&
+      env KREW_ROOT="${krew_root}" "$KREW" update
+  )
+}
+
+install_plugin() {
+  plugin="${2}"
+
+  run_krew "${1}" install "${plugin}" 1>/dev/null
+}
+
+# patch_krew_bin replaces the installed krew binary with the new version
+patch_krew_bin() {
+  krew_root="${1}"
+  new_binary="${2}"
+
+  local old_binary
+  old_binary="$(readlink -f "${krew_root}/bin/kubectl-krew")"
+  cp -f "${new_binary}" "${old_binary}"
+}
+
+# run_krew runs 'krew' with the specified KREW_ROOT and arguments.
+run_krew() {
+  krew_root="${1}"
+  shift
+
+  # TODO(chriskim06): remove multi index flag once feature gate is removed
+  env KREW_ROOT="${krew_root}" \
+    PATH="${krew_root}/bin:$PATH" \
+    X_KREW_ENABLE_MULTI_INDEX=1 \
+    kubectl krew "$@"
+}
+
+verify_index_migrated() {
+  krew_root="${1}"
+  [[ -d "${krew_root}/index/default" ]]
+}
+
+main() {
+  new_krew="${BINDIR}/krew-${goos}_${goarch}"
+  if [[ ! -e "${new_krew}" ]]; then
+    echo >&2 "Could not find ${new_krew}."
+    exit 1
+  fi
+
+  krew_root="$(mktemp -d)"
+  trap 'rm -rf "${krew_root}"' RETURN
+
+  echo >&2 "Test directory: ${krew_root}"
+  install_krew_0_3_4 "${krew_root}"
+  install_plugin "${krew_root}" "get-all"
+  echo >&2 "Swapping krew binary"
+  patch_krew_bin "${krew_root}" "${new_krew}"
+  run_krew "${krew_root}" list || (
+    echo >&2 "krew list is failing"
+    exit 1
+  )
+  verify_index_migrated "${krew_root}" || (
+    echo >&2 "index was not migrated"
+    exit 1
+  )
+}
+
+main