add vagrant plugin

[huazhihao]

kube-vagrant is a kubectl plugin to create a multi-node kubernetes cluster locally with vagrant, so you can quickly set up a dev cluster with one command line.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huazhihao
To complete the pull request process, please assign corneliusweig
You can assign the PR to them by writing /assign @corneliusweig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huazhihao
To complete the pull request process, please assign corneliusweig
You can assign the PR to them by writing /assign @corneliusweig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[corneliusweig]

Hey @huazhihao,

this is great work, but I'm not sure it qualifies for a good plugin. As far as I can tell, this is usually a one-time setup, so that the plugin gets to run just a single time. Scripts like these have also previously been rejected as plugins, because krew's focus is on repeatable commands. For example, there was a request to have a tiller installer for helm-2 which eventually got rejected (#87).

Let's hear @ahmetb's opinion about this.

Btw, this looks dangerous 😉 https://github.com/huazhihao/kube-vagrant/blob/c3eee010eea50be7fdfd9882c657b76a43d1bebe/kube-vagrant#L194

[ahmetb]

Yes, cluster bootstrap tooling it not great for plugins.
Similarly Vagrant is a trademark of HashiCorp so we’ll not be able to accept it.
You’re free to still distribute it outside krew, however.

[huazhihao]

thanks @corneliusweig @ahmetb for your review comments. I will leave it as-is.

[huazhihao]

Hey @huazhihao,

this is great work, but I'm not sure it qualifies for a good plugin. As far as I can tell, this is usually a one-time setup, so that the plugin gets to run just a single time. Scripts like these have also previously been rejected as plugins, because krew's focus is on repeatable commands. For example, there was a request to have a tiller installer for helm-2 which eventually got rejected (#87).

Let's hear @ahmetb's opinion about this.

Btw, this looks dangerous 😉 https://github.com/huazhihao/kube-vagrant/blob/c3eee010eea50be7fdfd9882c657b76a43d1bebe/kube-vagrant#L194

that wasn't under home directory.

[corneliusweig]

that wasn't under home directory.

As far as I can tell, the directory is unspecified. So it could be any directory, including $HOME. Right?