Support additional GCPManagedControlPlane fields #1186

akshay196-rafay · 2024-03-20T07:39:57Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add following GCPManagedControlPlane fields:

Description
Cluster Network
- PrivateCluster
- UseIPAliases
- Pod
- Service
Cluster Security
- WorkloadIdentityConfig
- AuthenticatorGroupConfig
- EnableLagacyAuthorization
- IssueClientCertificate
AddonsConfig
LoggingConfig
MonitoringConfig

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #906

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
includes documentation
adds unit tests

Release note:

TBD

k8s-ci-robot · 2024-03-20T07:40:06Z

Hi @akshay196-rafay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2024-03-20T07:40:13Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name	Link
🔨 Latest commit	`822ae06`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/667b321ff1e929000893d56d
😎 Deploy Preview	https://deploy-preview-1186--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cpanato · 2024-03-20T07:50:58Z

/ok-to-test
/test all

richardcase · 2024-03-27T08:05:51Z

@akshay196-rafay - would you be able to look at the lint issues?

richardcase · 2024-05-07T11:11:07Z

/retest

richardcase · 2024-05-07T11:12:43Z

@akshay196-rafay @aniruddha2000 - would you be able to do a make generate? Lets try and get this PR merged.

FrancoisKlieberOrange · 2024-05-21T15:07:07Z

Hi @akshay196-rafay @aniruddha2000,

I hope you're doing well.

I just wanted to reach out to see if there's anything I can do to help you with it. If you're stuck on something or could use an extra set of eyes to review or troubleshoot, I'd be more than happy to assist.

Please feel free to let me know how I can support you, whether it's discussing the issue, collaborating on a solution, or just providing some feedback. I'm here to help!

Best regards,
Francois

- Description - Cluster Network - PrivateCluster - UseIPAliases - Pod - Service - Cluster Security - WorkloadIdentityConfig - AuthenticatorGroupConfig - EnableLagacyAuthorization - IssueClientCertificate - AddonsConfig - LoggingConfig - MonitoringConfig Signed-off-by: Aniruddha Basak <[email protected]> Signed-off-by: Akshay Gaikwad <[email protected]>

Signed-off-by: Akshay Gaikwad <[email protected]>

linux-foundation-easycla · 2024-06-20T09:15:07Z

The committers listed above are authorized under a signed CLA.

✅ login: aniruddha2000 / name: Aniruddha Basak (0740d35)
✅ login: belgaied2 / name: Mohamed Belgaied Hassine (822ae06, 23e3d97, 60f60c5)
✅ login: akshay196-rafay / name: Akshay Gaikwad (41d4bd4)

… its pre-requisite of go version in go.mod Signed-off-by: Mohamed Belgaied Hassine <[email protected]>

…fig for private GKE clusters and removing non-urgent API additions Signed-off-by: Mohamed Belgaied Hassine <[email protected]>

Signed-off-by: Mohamed Belgaied Hassine <[email protected]>

belgaied2 · 2024-06-25T21:26:39Z

@cpanato @richardcase this PR has been dramatically reduced in scope in the hope of a faster merge.
The focus is set on GKE Private clusters.

Some effort has been done to have all CI tests pass. Please, review and let me know if I should improve anything.

dims · 2024-06-26T13:00:40Z

/approve
/lgtm

k8s-ci-robot · 2024-06-26T13:00:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akshay196-rafay, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dims · 2024-06-26T13:04:13Z

exp/api/v1beta1/gcpmanagedcontrolplane_types.go

+
+	// Pod defines the range of CIDRBlock list from where it gets the IP address.
+	// +optional
+	Pod *ClusterNetworkPod `json:"pod,omitempty"`


We don't use this field in this PR ... do we?

dims · 2024-06-26T13:04:23Z

exp/api/v1beta1/gcpmanagedcontrolplane_types.go

+
+	// Service defines the range of CIDRBlock list from where it gets the IP address.
+	// +optional
+	Service *ClusterNetworkService `json:"service,omitempty"`


Same question as above

k8s-ci-robot requested review from dims and richardcase March 20, 2024 07:40

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 20, 2024

akshay196 mentioned this pull request Mar 20, 2024

Support additional fields for GKE #906

Closed

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2024

akshay196-rafay force-pushed the gcpmanagedcontrolplane-additional-fields branch from f5e6b5b to 89fb7f2 Compare March 20, 2024 08:00

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2024

akshay196 mentioned this pull request Mar 20, 2024

Add fields to the GCPManagedControlPlane types #936

Closed

2 tasks

akshay196-rafay force-pushed the gcpmanagedcontrolplane-additional-fields branch from 89fb7f2 to be350e5 Compare March 20, 2024 08:04

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 20, 2024

akshay196-rafay force-pushed the gcpmanagedcontrolplane-additional-fields branch from be350e5 to fc5d3c3 Compare March 27, 2024 11:30

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2024

akshay196-rafay force-pushed the gcpmanagedcontrolplane-additional-fields branch from fc5d3c3 to 5849651 Compare April 1, 2024 10:17

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024

richardcase marked this pull request as ready for review May 7, 2024 11:09

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024

k8s-ci-robot requested a review from cpanato May 7, 2024 11:09

richardcase changed the title ~~Support additional GCPManagedControlPlane fields~~ [WIP] Support additional GCPManagedControlPlane fields May 7, 2024

aniruddha2000 and others added 2 commits June 20, 2024 10:31

Reconcile GCPManagedControlPlane new settings

41d4bd4

Signed-off-by: Akshay Gaikwad <[email protected]>

belgaied2 force-pushed the gcpmanagedcontrolplane-additional-fields branch from 5849651 to e7b3f53 Compare June 20, 2024 09:15

belgaied2 added 2 commits June 21, 2024 15:11

Removed parts of the newly added API objects, did a make generate and…

60f60c5

… its pre-requisite of go version in go.mod Signed-off-by: Mohamed Belgaied Hassine <[email protected]>

Adding support for DisableDefaultSNAT and MasterAuthorizedNetworksCon…

23e3d97

…fig for private GKE clusters and removing non-urgent API additions Signed-off-by: Mohamed Belgaied Hassine <[email protected]>

belgaied2 force-pushed the gcpmanagedcontrolplane-additional-fields branch from e7b3f53 to 23e3d97 Compare June 25, 2024 21:04

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 25, 2024

Removed a temporary change to config YAMLs

822ae06

Signed-off-by: Mohamed Belgaied Hassine <[email protected]>

belgaied2 force-pushed the gcpmanagedcontrolplane-additional-fields branch from 5cd086c to 822ae06 Compare June 25, 2024 21:09

akshay196-rafay changed the title ~~[WIP] Support additional GCPManagedControlPlane fields~~ Support additional GCPManagedControlPlane fields Jun 26, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024

k8s-ci-robot assigned dims Jun 26, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024

k8s-ci-robot merged commit 1eb50ed into kubernetes-sigs:main Jun 26, 2024
18 checks passed

k8s-ci-robot added this to the v1.1.0 milestone Jun 26, 2024

dims reviewed Jun 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support additional GCPManagedControlPlane fields #1186

Support additional GCPManagedControlPlane fields #1186

akshay196-rafay commented Mar 20, 2024 •

edited

Loading

k8s-ci-robot commented Mar 20, 2024

netlify bot commented Mar 20, 2024 •

edited

Loading

cpanato commented Mar 20, 2024

richardcase commented Mar 27, 2024

richardcase commented May 7, 2024

richardcase commented May 7, 2024

FrancoisKlieberOrange commented May 21, 2024

linux-foundation-easycla bot commented Jun 20, 2024 •

edited

Loading

belgaied2 commented Jun 25, 2024 •

edited

Loading

dims commented Jun 26, 2024

k8s-ci-robot commented Jun 26, 2024

dims Jun 26, 2024

dims Jun 26, 2024

Support additional GCPManagedControlPlane fields #1186

Support additional GCPManagedControlPlane fields #1186

Conversation

akshay196-rafay commented Mar 20, 2024 • edited Loading

k8s-ci-robot commented Mar 20, 2024

netlify bot commented Mar 20, 2024 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

cpanato commented Mar 20, 2024

richardcase commented Mar 27, 2024

richardcase commented May 7, 2024

richardcase commented May 7, 2024

FrancoisKlieberOrange commented May 21, 2024

linux-foundation-easycla bot commented Jun 20, 2024 • edited Loading

belgaied2 commented Jun 25, 2024 • edited Loading

dims commented Jun 26, 2024

k8s-ci-robot commented Jun 26, 2024

dims Jun 26, 2024

Choose a reason for hiding this comment

dims Jun 26, 2024

Choose a reason for hiding this comment

akshay196-rafay commented Mar 20, 2024 •

edited

Loading

netlify bot commented Mar 20, 2024 •

edited

Loading

linux-foundation-easycla bot commented Jun 20, 2024 •

edited

Loading

belgaied2 commented Jun 25, 2024 •

edited

Loading