-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: basic netlify configuration for book #1131
docs: basic netlify configuration for book #1131
Conversation
Hi @salasberryfin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-tesr |
@richardcase I think there's a typo in the to-test label and prow didn't start the checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
d6578e3
to
dabda52
Compare
Fixed tests and it is now ready to be reviewed. |
dabda52
to
b9291b3
Compare
Signed-off-by: Carlos Salas <[email protected]>
b9291b3
to
b63fdd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
thanks for working on this
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds the basic
netlify
configuration (plus minimal make tools for building the book) so that we can request anetlify
site and a project subdomain.Together with this PR, I'm opening the necessary requests in the https://github.com/kubernetes/k8s.io/ repository.
Then, when the site is up and running, I'll create a separate PR to add the base structure/contents of the book, so that we can later iterate over this and add new/improve existing topics.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
This the initial PR on an effort to sort the CAPG docs into a book #490.
TODOs:
Release note: