-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove v1alpha4 API types #1120
⚠️ Remove v1alpha4 API types #1120
Conversation
/hold for tests / consensus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @vincepri
/approve
/lgtm
will wait for @richardcase then we can lift the hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks good to me. After the rebase lets get this in |
Seems good to me. After a rebase i think we are good to merge this. |
Signed-off-by: Vince Prignano <[email protected]>
af8c92e
to
5a9f127
Compare
Thanks! I'd rename the commit/PR title to just v1alpha4 API types, as the v1alpha3 were removed in the CAPI 1.6.x bump PR. Then LGTM |
Signed-off-by: Vince Prignano <[email protected]>
5a9f127
to
39d3e91
Compare
/hold cancel |
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
What type of PR is this?
What this PR does / why we need it:
These APIs have been deprecated in their upstream counterpart, and soon be removed.
Let's remove them in the next version?
/kind api-change
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: