Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

docker: upgrade to golang 1.21 and alpine 3.18 #526

Merged
merged 2 commits into from
Aug 28, 2023
Merged

docker: upgrade to golang 1.21 and alpine 3.18 #526

merged 2 commits into from
Aug 28, 2023

Conversation

mcluseau
Copy link
Contributor

@mcluseau mcluseau commented Aug 27, 2023 •
edited
Loading

Upgrade versions used in the docker, and also upgrade Ginkgo so it's the same as the CLI, allowing the tests to run.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mcluseau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2023
@mcluseau mcluseau force-pushed the docker-upgrade branch 2 times, most recently from af0aab2 to 6adf82c Compare August 27, 2023 13:05
@mcluseau mcluseau mentioned this pull request Aug 27, 2023
Closed
@mcluseau mcluseau changed the title [DNM] docker: upgrade to golang 1.21 and alpine 3.18 docker: upgrade to golang 1.21 and alpine 3.18 Aug 27, 2023
@mcluseau
Copy link
Contributor Author

@jayunit100 is it lgtm for you? :)

@qabpea
Copy link

qabpea commented Aug 28, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 307a4dd into kubernetes-retired:master Aug 28, 2023
22 checks passed
@jayunit100
Copy link
Contributor

Ah thxxxx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@astoycos astoycos Awaiting requested review from astoycos

@qabpea qabpea Awaiting requested review from qabpea

Assignees

@qabpea qabpea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcluseau @k8s-ci-robot @qabpea @jayunit100