Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Load ipvs modules before enabling conntrack #521

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

mneverov
Copy link
Contributor

What kind of PR is this?

Bugfix

Why this PR is needed / What this PR do?

This PR loads ipvs modules.

Which issue(s) this PR fixes?

When run locally with ipvs as a backend, kpng fail to start with error:

setup.go:36] unable to initialize ipvs managererror can't set sysctl net/ipv4/vs/conntrack to 1: open /proc/sys/net/ipv4/vs/conntrack: no such file or directory

The error occur because ipvs modules are not loaded, so there is no /proc/sys/net/ipv4/vs directory and the file conntrack cannot be created.

Fixes #

Additional information about this PR

kind --version
kind version 0.20.0

Node is running Ubuntu 22.04.2 LTS:

cat /proc/sys/kernel/osrelease
6.2.0-26-generic

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 22, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can move both the changes in a separate commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@aroradaman
Copy link
Contributor

Thank you @mneverov for the PR,
have requested few changes.

@aroradaman
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2023
@aroradaman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2023
@mneverov
Copy link
Contributor Author

@aroradaman @mcluseau the reason ipvs backend works in e2e tests is that ipvsadm is installed and initialized, which creates the .../vs folder. I wonder if this step can be removed now.

@aroradaman
Copy link
Contributor

@aroradaman @mcluseau the reason ipvs backend works in e2e tests is that ipvsadm is installed and initialized, which creates the .../vs folder. I wonder if this step can be removed now.

@mneverov can you create a new PR removing the step you mentioned to test that out 🙂

@aroradaman
Copy link
Contributor

/approve
thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aroradaman, mneverov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@mneverov mneverov mentioned this pull request Aug 23, 2023
@mneverov
Copy link
Contributor Author

@aroradaman @mcluseau the reason ipvs backend works in e2e tests is that ipvsadm is installed and initialized, which creates the .../vs folder. I wonder if this step can be removed now.

@mneverov can you create a new PR removing the step you mentioned to test that out 🙂

@aroradaman ptal #522

@k8s-ci-robot k8s-ci-robot merged commit 82bbfbb into kubernetes-retired:master Aug 25, 2023
21 of 22 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants