Fix: Update containerized-python-components.md. fixes #3871 #3873
Conversation
Minor updates to make the documentation work Signed-off-by: Marie Stephen Leo <[email protected]>
|
Hi @stephenleo. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kubeflow/kubeflow-steering-committee can please help to review this change? |
| @@ -62,17 +62,18 @@ src/ | |||
| In this step, you'll provide `base_image` and `target_image` arguments to the `@dsl.component` decorator of your component in `src/my_component.py`: | |||
|
|
|||
| ```python | |||
| @dsl.component(base_image='python:3.7', | |||
| @dsl.component(base_image='python:3.11', | |||
There was a problem hiding this comment.
Can we use Python 3.9, which is still supported?
There was a problem hiding this comment.
We support any >= 3.9 and due to that it is the website. It is fine to use 3.11
There was a problem hiding this comment.
Shouldn't we use 3.12 then? I mean, the lowest or the highest.
There was a problem hiding this comment.
It can be anything as long as it matches one of the items declared in: https://github.com/kubeflow/pipelines/blob/master/sdk/python/setup.py#L100
| return add_numbers(a, b) | ||
| ``` | ||
|
|
||
| Setting `target_image` both (a) specifies the [tag][image-tag] for the image you'll build in Step 3, and (b) instructs KFP to run the decorated Python function in a container that uses the image with that tag. | ||
|
|
||
| In a Containerized Python Component, `base_image` specifies the base image that KFP will use when building your new container image. Specifically, KFP uses the `base_image` argument for the [`FROM`][docker-from] instruction in the Dockerfile used to build your image. | ||
|
|
||
| The previous example includes `base_image` for clarity, but this is not necessary as `base_image` will default to `'python:3.7'` if omitted. | ||
| The previous example includes `base_image` for clarity, but this is not necessary as `base_image` will default to `'python:3.11'` if omitted. |
There was a problem hiding this comment.
Same as above regarding Python 3.9.
There was a problem hiding this comment.
As mentioned earlier, I’m open to either Python 3.9 or Python 3.11. I trust your judgment, so whichever you choose works for me.
|
@diegolovison are you willing to take a look at this? |
|
@stephenleo can you edit #3873 (comment) to link this PR to the issue? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes the documentation for containerized Python components. The current documentation doesn't work and errors out as described in #3871
pipeline.py