Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken link in central dashboard #3830

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fixed broken link in central dashboard #3830

merged 1 commit into from
Sep 23, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Jul 29, 2024 •
edited
Loading

Resolves #3809

@google-oss-prow Google OSS Prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hbelmiro hbelmiro changed the title issue-3809 WIP Fixed broken link in central dashboard Jul 29, 2024
@hbelmiro hbelmiro marked this pull request as ready for review July 29, 2024 19:34
@hbelmiro
Copy link
Contributor Author

@andreyvelich can you please take a look?

@hbelmiro hbelmiro mentioned this pull request Jul 29, 2024
Open
6 tasks
@varodrig varodrig mentioned this pull request Sep 21, 2024
Closed
@hbelmiro
Copy link
Contributor Author

@andreyvelich @terrytangyuan mind taking a look?

terrytangyuan
terrytangyuan reviewed Sep 23, 2024
View reviewed changes
netlify.toml
@@ -27,7 +27,6 @@ package = "netlify-plugin-checklinks"

# If a link contains these patterns it will not fail the build, but will be reported as a TODO in the build log.
todoPatterns = [
"public/docs/components/central-dash/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing this? I am not familiar with this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line adds the public/docs/components/central-dash/ to the white list of checklinks. Broken links under those directories are ignored during the CI.
This PR fixes all the broken links under that directory. Therefore we can now remove the directory from the white list so the CI verifies for broken links there too.

@terrytangyuan
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 23, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b83d113 into kubeflow:master Sep 23, 2024
6 checks passed
@hbelmiro hbelmiro deleted the issue-3809 branch September 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@james-jwu james-jwu Awaiting requested review from james-jwu

@jbottum jbottum Awaiting requested review from jbottum

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

Assignees

@terrytangyuan terrytangyuan

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken links in Central Dashboard
2 participants
@hbelmiro @terrytangyuan