Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset of metadata fields #113

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Conversation

rsevilla87
Copy link
Member

@rsevilla87 rsevilla87 commented Sep 26, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Follow-up of kube-burner/kube-burner#702
As agreed with the team (cc @mukrishn), let's add a small subset of metadata fields to all metrics (ocpVersion and ocpMajorVersion) generated by kube-burner.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

go.mod Outdated Show resolved Hide resolved
@rsevilla87 rsevilla87 force-pushed the minimal-metadata branch 3 times, most recently from cbe6ed4 to ef52eef Compare September 26, 2024 13:12
go.mod Outdated Show resolved Hide resolved
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Copy link
Contributor

@venkataanil venkataanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@venkataanil venkataanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krishvoor krishvoor merged commit ee6426d into kube-burner:main Oct 9, 2024
4 checks passed
@rsevilla87 rsevilla87 deleted the minimal-metadata branch October 9, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants