Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cisco_xr.py exit_config_mode function #3420

Merged
merged 2 commits into from
May 16, 2024

Conversation

rajjaisur
Copy link
Contributor

Cisco_xr exit_config_mode function in case of uncommitted changes error.
The current function is not working in case of uncommitted changes. because the output is until "uncommitted". function matching is for "Uncommitted changes found" .

Cisco_xr exit_config_mode function in case of uncommitted changes error.
@ktbyers
Copy link
Owner

ktbyers commented Apr 29, 2024

You are going to have to expand on the issue you are seeing i.e. the current code should work with this string from IOS-XR:

RP/0/0/CPU0:ios-xrv(config)#end
Uncommitted changes found, commit them before exiting(yes/no/cancel)? [cancel]:

@ktbyers
Copy link
Owner

ktbyers commented May 2, 2024

@rajjaisur Any updates on my question on why this change is needed?

@rajjaisur
Copy link
Contributor Author

No it will not because current code is only reading till Uncommitted not full sentence.

@ktbyers ktbyers merged commit 5547ba6 into ktbyers:develop May 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants