Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a SessionLog object for session_log in __init__.py #3313

Merged
merged 12 commits into from
Oct 18, 2023

Conversation

ktbyers
Copy link
Owner

@ktbyers ktbyers commented Oct 18, 2023

No description provided.

@ktbyers
Copy link
Owner Author

ktbyers commented Oct 18, 2023

@dannywade FYI, I made some minor updates to the test code (call .open(), there was a missing .get, and needed to place at the end of tests).

I needed to relocate it to the end of the tests is the test doesn't reinitialize so using a SessionLog object was breaking some of the tests that followed it (hence I made it be the last test).

@ktbyers
Copy link
Owner Author

ktbyers commented Oct 18, 2023

test_netmiko_session_log.py::test_session_log PASSED
test_netmiko_session_log.py::test_session_log_write PASSED
test_netmiko_session_log.py::test_session_log_append PASSED
test_netmiko_session_log.py::test_session_log_secrets PASSED
test_netmiko_session_log.py::test_logging_filter_secrets PASSED
test_netmiko_session_log.py::test_unicode PASSED
test_netmiko_session_log.py::test_session_log_bytesio PASSED
test_netmiko_session_log.py::test_session_log_custom_secrets PASSED

@ktbyers ktbyers merged commit 674f48c into develop Oct 18, 2023
10 checks passed
@dannywade
Copy link
Contributor

@ktbyers Thank you! When are you planning the next release of netmiko?

@ktbyers
Copy link
Owner Author

ktbyers commented Oct 19, 2023

@dannywade Maybe a month or so. I don't have a specific date.

You should be able to use the develop branch, however, so I should not be gating you.

@ktbyers ktbyers deleted the session_log_obj branch February 28, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants