Changed raids.RDS.aws to raids.rds #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Knight <[email protected]>
eddie-knight
force-pushed
the
config-handling
branch
from
4cea63f
to
dab9fc2
Compare
krumware
reviewed
Oct 29, 2023
There was a problem hiding this comment.
I don't really want to lose the .aws. level, but the config should definitely move to the normal level like this.
That way the db config can stay in one spot but we can introduce config sections specific to other adapters/clis later.
Can we keep just the AWS section how it was?
|
I think I see what you mean, putting up a new commit momentarily |
Signed-off-by: Eddie Knight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the long-term vision is to limit the scope of each raid that we're asking folks to maintain, this raid should only encompass AWS. If Krumware wants to maintain additional raids for other RDMS services, that's absolutely awesome.
As such, we can limit the RDS config to simply
raids.rds.xAny pushback/critique/improvement is welcome in comments or via slack.