Add set in table creation #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… entries (or keys, if passed as the last argument) via the Range object.
…n via a `cql_type` tag.
| return s, found | ||
| } | ||
|
|
||
| func (t *typeMap) set(rt r.Type, v *StructInfo) { |
There was a problem hiding this comment.
The setter is only used internally so shouldn't be exposed to the outside world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: I needed a way to tell gocqltable to handle a slice in the model struct definition as a set in CQL and not as a list.
Not really happy with the amount of code needed to get this in here. Along the way, I fixed a few of
go vet's concerns regarding certain code constructs, safely exposed the struct information map to the outside world (now usable in your project using gocqltable) and added a way to query indexed map/list/set values (or keys) via CQL'sCONTAINSclause. There's a few basic tests added in there as well so maybe there's parts of this you want to pull into upstream.I'll be using Go 1.6's vendor feature to embed my fork in the current project (forks were a real pain before – maybe we should do this for the dependencies of gocqltable as well?) so I'm not in a rush to get this merged.
Thanks for the library!