Skip to content
This repository has been archived by the owner on Aug 27, 2023. It is now read-only.

Add Dockerfile and instructions for local setup #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

themousepotato
Copy link
Member

No description provided.

@thealphadollar
Copy link
Member

thealphadollar commented Nov 10, 2018

@themousepotato It would be amazing if we can have two docker-files; one with proxy and other without it 😄

@themousepotato
Copy link
Member Author

@thealphadollar That would be an overkill IMO. We can override env vars by passing a -e VARNAME=varvalue on the docker run command.

@thealphadollar
Copy link
Member

That's great. Then I would request you to make the docker file independent of env variables and put in README the variables to be set when running from KGP and outside.

@themousepotato
Copy link
Member Author

Let's not worry about this now. We'll write a docker-compose.yml later and deal with it. It'll simplify a lot of tasks on deployment. I need to know about the various services that we use. For the local setup, the current Dockerfile works fine. Ping @americast @dibyadas .

@kshitij10496 kshitij10496 requested review from kshitij10496 and removed request for kshitij10496 November 10, 2018 17:30
@thealphadollar
Copy link
Member

@themousepotato Well, after learning how we deploy the website on the DO server I would say this is a process we don't need at the moment. Since we are low on time and we already have everything set on the server, I would not be interested in changing the working settings and shift to this. After KWoC we can sit one day and shift the deployment method.

cc/ @DefCon-007

@Ayushk4
Copy link
Member

Ayushk4 commented Dec 13, 2018

Accidently closed this 😅.

@thealphadollar
Copy link
Member

@themousepotato Anthing up on this?

@themousepotato
Copy link
Member Author

CTMs can work on this.

cc @grapheo12 @mukul-mehta @Shankusu993 et al.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants