Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added-types #225

Open
wants to merge 1 commit into
base: truth-redefined-again
Choose a base branch
from

Conversation

pratham-srivastava-07
Copy link

Added types to the frontend project.

Copy link

vercel bot commented Dec 19, 2023

@pratham-srivastava-07 is attempting to deploy a commit to the kossiitkgp Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert changes that are not relevant to your PR?

@pratham-srivastava-07
Copy link
Author

please clarify where I have to revert the changes...would be helpful.

@harshkhandeparkar
Copy link
Member

I think you have misunderstood the issue. We are extremely sorry since we did not explain it properly. We were referring the Backend endpoint types defined here. We wanted to add types for the remaining endpoints.

@pratham-srivastava-07
Copy link
Author

okay...so should I try this one more time properly?

@harshkhandeparkar
Copy link
Member

okay...so should I try this one more time properly?

Sure! Sorry for the inconvenience.

@pratham-srivastava-07
Copy link
Author

so just for confirmation changes only have to be done in types.ts?

@harshkhandeparkar
Copy link
Member

so just for confirmation changes only have to be done in types.ts?

Yes.

@pratham-srivastava-07
Copy link
Author

can we have a quick sync up on meet? @harshkhandeparkar

@harshkhandeparkar
Copy link
Member

can we have a quick sync up on meet? @harshkhandeparkar

What do you want to discuss?

@pratham-srivastava-07
Copy link
Author

i am still having problems understanding what exactly needs to be done

@harshkhandeparkar
Copy link
Member

i am still having problems understanding what exactly needs to be done

Are you familiar with the KWoC Backend API endpoints? We have a wrapper function in the frontend that makes an API request and returns the result, and it maps every endpoint to its return type. But some endpoint types are still not present in the frontend. Adding them was the issue.

@pratham-srivastava-07
Copy link
Author

okay

@harshkhandeparkar
Copy link
Member

This is not a huge priority. We do keep adding types as the need arises. If you don't feel comfortable continuing with this, it is fine. Other issues are always open :)

@pratham-srivastava-07
Copy link
Author

okay will try one more time...if thats okay

@harshkhandeparkar
Copy link
Member

okay will try one more time...if thats okay

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants