Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
with the Skia renderer, flag emojis (Noto) such as 🇯🇵 exceed their bounds.
This is what the Japan flag emoji looks like:
Other emojis are properly sized and look like this:
The main difference I could spot is that flag emojis seem to have an explicit width and height, while others use a
viewBox
. In this case, Skia seems to ignore the call toimage.dom.setContainerSize(...)
inSVGImage
.I've found a workaround that scales both kinds of emojis better by using
canvas.scale(scaleFactor, scaleFactor)
.The result looks like this: