Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added naive ONNX support #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shijianjian
Copy link
Member

No description provided.

@lferraz
Copy link
Member

lferraz commented Apr 16, 2023

thanks for the contribution.
A couple of things:

  • new components must be added in limbus_components_dev, please check the README.
  • any reason to have all the variables and methods public in the onnx component?

We know this component does not follow the standard API, for now it is fine, but in the near future we will need to solve it.

UPDATE: I found a bug in the release script. I will let you know once it is addressed
UPDATE 2: issue addressed, was not a bug, it was me forgeting how to use the script. I added a description in the README.

@shijianjian
Copy link
Member Author

Yeah. I feel like such code should be added into the factory to generate model-specific class for each ONNX model. The whole repo does not aim at a generic class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants