-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add IBM VPC contract default transformer #35
base: main
Are you sure you want to change the base?
Conversation
Thanks for making a pull request! 😃 |
f2170cc
to
efbb92d
Compare
do not merge |
566835c
to
3246216
Compare
403413f
to
7ad9897
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does having two template, one for encrypted and another for non encrypted necessiate them to be in sync.
If so, is there a way to remove this requirement.
# Creates IBM VPC contract file | ||
def transform(new_artifacts, old_artifacts): | ||
ibmHyperProtectCert = """ | ||
-----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to move this to a file and read from the file.
a07fa12
to
1f7d91c
Compare
9d54ea9
to
d3f24e1
Compare
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
…ansformer. add env and workload templates Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
…ract generation Signed-off-by: Mehant Kammakomati <[email protected]>
d3f24e1
to
0b88d7f
Compare
Signed-off-by: Mehant Kammakomati <[email protected]>
* Volume Section creation fix * Updating latest Fixes for contract creation
Signed-off-by: Harikrishnan Balagopal <[email protected]>
Signed-off-by: Harikrishnan Balagopal <[email protected]>
…resent Signed-off-by: Harikrishnan Balagopal <[email protected]>
…ry (#3) Signed-off-by: Harikrishnan Balagopal <[email protected]>
Signed-off-by: Harikrishnan Balagopal <[email protected]>
Signed-off-by: Harikrishnan Balagopal <[email protected]>
…aracter (padding) Signed-off-by: Harikrishnan Balagopal <[email protected]>
Signed-off-by: Mehant Kammakomati [email protected]