Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strongly typed response for listing variants by type #271

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

DiegoFaFe
Copy link
Contributor

@DiegoFaFe DiegoFaFe commented Jun 16, 2024

Motivation

Which issue does this fix? Fixes #146

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Added the method to return strongly typed variants when filtering by type.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@DiegoFaFe DiegoFaFe requested review from pokornyd and a team as code owners June 16, 2024 21:20
@pokornyd
Copy link
Member

hello Diego, thanks for the PR. I'll review the proposed changes and come back to you with any remarks, thanks for your patience.

@pokornyd
Copy link
Member

I took the liberty of solution-wide refactoring of some null checks and unnecessary lambdas. the method implementation and tests are in line with the rest of the code, approving and merging

@pokornyd pokornyd merged commit 366e496 into kontent-ai:master Aug 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing method for strongly typed language variants
2 participants