Add k3s GitHub #758

DrummyFloyd · 2024-05-21T00:12:30Z

becasue i saw many ppl asking for the github templates, there it is

still need some test especially on TF parts

fix some gitlab template based on feat: gitlab runner #771
fix TF_VAR_ssh_private_key , now passed the content from ARG to K1-API as TF_VAR fix: pass SSH private key content as environment variable for K3s kubefirst-api#353

github-actions · 2024-05-21T00:12:42Z

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

fharper · 2024-05-21T12:32:20Z

Thanks for the PR @DrummyFloyd 🎉

This PR will close konstructio/kubefirst#2146 .

I will try to test it today, but it will probably have to be tomorrow, sorry.

fharper · 2024-05-23T14:29:36Z

We won't be able to merge this yet as to add the GitHub support, we also need to update the https://github.com/kubefirst/kubefirst-api and https://github.com/kubefirst/kubefirst-api unless it was done already when you added K3s support. I need to check that first.

DrummyFloyd · 2024-05-23T15:07:12Z

We won't be able to merge this yet as to add the GitHub support, we also need to update the https://github.com/kubefirst/kubefirst-api and https://github.com/kubefirst/kubefirst-api unless it was done already when you added K3s support. I need to check that first.

if i remember well, it should already be on the code

but yes could be great to check =)

EDIT:
https://github.com/kubefirst/kubefirst-api/blob/5ba2497ec8f15c4f7380ff23c52d7648f83f17e7/internal/controller/git.go#L95
https://github.com/kubefirst/kubefirst/blob/986fea4d7576d1b495e949b4ec0795ec2a9ed08d/cmd/k3s/command.go#L101C119-L101C140

fharper · 2024-05-30T18:27:06Z

I was trying again the GitLab one before to ensure everything is fine on my side before trying this PR, but I get his error with the latest kubefirst release (not this branch):

{"level":"debug","time":"2024-05-30T18:23:52Z","message":"ERR: \u001b[31m╷\u001b[0m\u001b[0m"}
{"level":"debug","time":"2024-05-30T18:23:52Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[1m\u001b[31mError: \u001b[0m\u001b[0m\u001b[1mMissing newline after argument\u001b[0m"}
{"level":"debug","time":"2024-05-30T18:23:52Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m"}
{"level":"debug","time":"2024-05-30T18:23:52Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[0m  on terraform.tfvars line 1:"}
{"level":"debug","time":"2024-05-30T18:23:52Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m   1: list_servers_private_ips = \"[\"\u001b[4m192.168.1.6\u001b[0m\",\"192.168.1.3\",\"192.168.1.5\"]\"\u001b[0m"}
{"level":"debug","time":"2024-05-30T18:23:52Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m"}
{"level":"debug","time":"2024-05-30T18:23:52Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mAn argument definition must end with a newline."}
{"level":"debug","time":"2024-05-30T18:23:52Z","message":"ERR: \u001b[31m╵\u001b[0m\u001b[0m"}

The command is how I wrote it at https://docs.kubefirst.io/k3s/quick-start/install/cli#create-your-new-kubefirst-cluster right?

If so, maybe something changed in the Terraform provider.

DrummyFloyd · 2024-05-30T18:35:11Z

the K3S tf provider is pinned so not a version provider issue

but if you took the exact same command as the doc say , there is some issue upon some parameters

github stuff with gitlab stuff, dunno

EDIT: from what i recall, @jarededwards did a TF provider to create the requirement stuff on CIVO VM
maybe something with TF version on your host ?

fharper · 2024-05-30T18:54:25Z

Oh yeah no, I use the correct GitLab parameters. I'll fix the docs. My question was mostly about the IPs since it's where the errors are. I created the VMs on Civo also, but it should work with any VMs anyway no? I would have assumed the issue was on my side, but the error is from Terraform while running the kubefirst command, not the script Jared created.

DrummyFloyd · 2024-05-30T19:05:10Z

Oh yeah no, I use the correct GitLab parameters. I'll fix the docs. My question was mostly about the IPs since it's where the errors are. I created the VMs on Civo also, but it should work with any VMs anyway no? I would have assumed the issue was on my side, but the error is from Terraform while running the kubefirst command, not the script Jared created.

if something change, upon the detokenize stuff, for me it should be related to this PR
konstructio/kubefirst-api@c9da2b8
But i don't see any relveant error ^^' so tbh dunno atm , what happn

maxiar · 2024-06-24T14:58:23Z

Hi! Any News?

DrummyFloyd · 2024-06-24T15:35:00Z

Hi! Any News?

i think it's still review =/ can't do nothing about it ^^
will ask to K1 team to have look asap if they have time =)

fharper · 2024-06-25T19:02:55Z

Sorry, the team is super busy, and I was on vacation. I had an issue with this integration when I tested. We quickly checked before I left, and I think we found the issue. I'll give it another go as soon as I'm done catching up on the last weeks.

@maxiar : note that you can try it yourself if you really need it asap. You'll need to use a custom gitops-template repository pointing to that branch. See https://docs.kubefirst.io/k3s/explore/gitops#using-your-own-gitops-template-repository-fork

maxiar · 2024-06-26T16:50:24Z

Sorry, the team is super busy, and I was on vacation. I had an issue with this integration when I tested. We quickly checked before I left, and I think we found the issue. I'll give it another go as soon as I'm done catching up on the last weeks.

@maxiar : note that you can try it yourself if you really need it asap. You'll need to use a custom gitops-template repository pointing to that branch. See https://docs.kubefirst.io/k3s/explore/gitops#using-your-own-gitops-template-repository-fork

Perfect! Good Vacations well deserved!! I will try to install the cluster using this branch "add-k3s-github", but we have a question, what version of the kuberfirst cli must be use? the latest? or compile from another WIP branch? Sorry for the dummy comment.. :)

fharper · 2024-06-26T17:10:35Z

When adding GitLab support, Drummy made sure GitHub was functional with the kubefirst CLI, so you only need to use this branch. To do so, add these flags (more information on the flags in the docs link I shared in my previous message) to the command for K3s (see https://docs.kubefirst.io/k3s/quick-start/install/cli/#create-your-new-kubefirst-cluster)

--gitops-template-url https://github.com/DrummyFloyd/gitops-template --gitops-template-branch add-k3s-github

I'm testing it right now, and with the fix I made before leaving for vacation, I'm passed the step where it was failing. So far so good, I'll keep you posted.

fharper · 2024-06-26T17:31:50Z

With the k3s PR, I have now an issue with the SSH key. The file is readable, and exist, but it seems like k1 can't find it.

{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m╷\u001b[0m\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[1m\u001b[31mError: \u001b[0m\u001b[0m\u001b[1mInvalid function argument\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[0m  on main.tf line 24, in module \"k3s\":"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m  24:         private_key = file(\u001b[4mvar.ssh_private_key\u001b[0m)\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m    \u001b[90m├────────────────\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[0m    \u001b[90m│\u001b[0m \u001b[1mvar.ssh_private_key\u001b[0m is \"/Users/fharper/.ssh/id_ed25519\""}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mInvalid value for \"path\" parameter: no file exists at"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\"/Users/fharper/.ssh/id_ed25519\"; this function works only with files that"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mare distributed as part of the configuration source code, so if this file"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mwill be created by a resource in this configuration you must instead obtain"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mthis result from an attribute of that resource."}

Any idea what is going on here?

I'll give a try to the GitLab one as it's been a while, to see if it's a GitHub issue, a k3s one, or probably a code 18 😅

DrummyFloyd · 2024-06-26T18:16:12Z

With the k3s PR, I have now an issue with the SSH key. The file is readable, and exist, but it seems like k1 can't find it.

{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m╷\u001b[0m\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[1m\u001b[31mError: \u001b[0m\u001b[0m\u001b[1mInvalid function argument\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[0m  on main.tf line 24, in module \"k3s\":"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m  24:         private_key = file(\u001b[4mvar.ssh_private_key\u001b[0m)\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m    \u001b[90m├────────────────\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[0m    \u001b[90m│\u001b[0m \u001b[1mvar.ssh_private_key\u001b[0m is \"/Users/fharper/.ssh/id_ed25519\""}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mInvalid value for \"path\" parameter: no file exists at"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\"/Users/fharper/.ssh/id_ed25519\"; this function works only with files that"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mare distributed as part of the configuration source code, so if this file"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mwill be created by a resource in this configuration you must instead obtain"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mthis result from an attribute of that resource."}

Any idea what is going on here?

I'll give a try to the GitLab one as it's been a while, to see if it's a GitHub issue, a k3s one, or probably a code 18 😅

will check this asap , will ping you on slack when it's done ) surely a template issue here like before !

EDIT: still debugging atm i don't know where this issue come from

@maxiar can you please try on your end and tell me if you can reproduce ?

DrummyFloyd · 2024-06-30T21:24:02Z

ok i reproduced and found the issue issue , need to discuss with k1 teams, about solutions , once i 've discussed ith them will push a hotfix for that =)
and the template should be fine !

maxiar · 2024-07-02T15:38:06Z

With the k3s PR, I have now an issue with the SSH key. The file is readable, and exist, but it seems like k1 can't find it.

{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m╷\u001b[0m\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[1m\u001b[31mError: \u001b[0m\u001b[0m\u001b[1mInvalid function argument\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[0m  on main.tf line 24, in module \"k3s\":"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m  24:         private_key = file(\u001b[4mvar.ssh_private_key\u001b[0m)\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m    \u001b[90m├────────────────\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[0m    \u001b[90m│\u001b[0m \u001b[1mvar.ssh_private_key\u001b[0m is \"/Users/fharper/.ssh/id_ed25519\""}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\u001b[0m"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mInvalid value for \"path\" parameter: no file exists at"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0m\"/Users/fharper/.ssh/id_ed25519\"; this function works only with files that"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mare distributed as part of the configuration source code, so if this file"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mwill be created by a resource in this configuration you must instead obtain"}
{"level":"debug","time":"2024-06-26T17:16:44Z","message":"ERR: \u001b[31m│\u001b[0m \u001b[0mthis result from an attribute of that resource."}

Any idea what is going on here?
I'll give a try to the GitLab one as it's been a while, to see if it's a GitHub issue, a k3s one, or probably a code 18 😅

will check this asap , will ping you on slack when it's done ) surely a template issue here like before !

EDIT: still debugging atm i don't know where this issue come from

@maxiar can you please try on your end and tell me if you can reproduce ?

Sorry for the delay, I have some problems with my cloud hosting services, but it's ready to test when you want...

fharper · 2024-07-02T15:50:50Z

@maxiar: wait for the next fix on this PR. As @DrummyFloyd wrote, he identified the issue, and we discussed the solutions, so a fix in coming.

maxiar · 2024-07-02T16:13:07Z

@maxiar: wait for the next fix on this PR. As @DrummyFloyd wrote, he identified the issue, and we discussed the solutions, so a fix in coming.

Perfect...

DrummyFloyd · 2024-07-04T00:47:46Z

hot fix made here
konstructio/kubefirst-api#353

seems to work on my end, but will ask for some test on k1 team to confirm that =)

fharper · 2024-07-04T13:11:53Z

The API changes are merged, will test this PR today.

maxiar · 2024-07-04T14:20:35Z

Hi! I try to test the fix using this command:

export GITHUB_TOKEN=XXXXXX

kubefirst beta k3s create \
    --servers-args "--disable traefik,--write-kubeconfig-mode 0644" \
    --alerts-email [email protected] \
    --domain-name maxiar.dev \
    --git-provider github \
    --servers-private-ips 10.0.1.2,10.0.1.3,10.0.1.1 \
    --servers-public-ips 65.21.63.182,95.217.216.146,37.27.15.187 \
    --ssh-privatekey ~/.ssh-tf-hetzner-cloud/id_rsa.key \
    --ssh-user root \
    --cluster-name kubefirst \
    --gitops-template-url https://github.com/DrummyFloyd/gitops-template \
    --gitops-template-branch add-k3s-github

but I get and error: Error: please provide a github organization using the --github-org flag because I've a personal account (https://github.com/maxiar) is not an organizacion.. It's mandatory? When I added --github-org maxiar but not works...

kubefirst beta k3s create \
    --servers-args "--disable traefik,--write-kubeconfig-mode 0644" \
    --alerts-email [email protected] \
    --domain-name maxiar.dev \
    --git-provider github \
    --github-org maxiar \
    --servers-private-ips 10.0.1.2,10.0.1.3,10.0.1.1 \
    --servers-public-ips 65.21.63.182,95.217.216.146,37.27.15.187 \
    --ssh-privatekey ~/.ssh-tf-hetzner-cloud/id_rsa.key \
    --ssh-user root \
    --cluster-name kubefirst \
    --gitops-template-url https://github.com/DrummyFloyd/gitops-template \
    --gitops-template-branch add-k3s-github

Error: something went wrong calling GitHub API during org lookup, http
status code is: 404, and response is: "{"message":"Not
Found","documentation_url":"https://docs.github.com/rest/orgs/members#get-
organization-membership-for-a-user","status":"404"}"

EDIT:: Another thing: I ommited the --dns-provider cloudflare parameter because I haven't a cloudfare account is it ok??
Can you help me? Thanks in advanced

fharper · 2024-07-04T14:22:27Z

It's mandatory? When I added --github-org maxiar but not works...

It is for clouds support that aren't k3d. You can create a free one with a free account on GitHub.

DrummyFloyd · 2024-07-04T15:34:57Z

It's mandatory? When I added --github-org maxiar but not works...

It is for clouds support that aren't k3d. You can create a free one with a free account on GitHub.

You will need make something like this for the sshbkey

--ssh-privatekey $(cat ~/.ssh/id_rsa)

and the dns-provider is mandatory

fharper · 2024-07-08T17:47:20Z

Why the cluster name is kubefirst and not maxiar (as cluster-name paramerter)?

kubefirst create an installer cluster and use k3d so k3s can use the API. It's the same for any clouds (except k3d), it all create a k3d cluster first, so it's normal.

Why I see in the logs.... "install k3d" or "Creating k3d cluster" instead k3s, it's very confusing..

See answer to your first question.

I get the same errors, using the latest kubefirst (binary, no compiled) and pass the --ssh-privatekey ~/.ssh/id_rsa (by file instead text), check this another logs..

It won't work, the change to receive the SSH key was done in the API, so this won't work until tou cat the content like you did in your first attempt.

{"level":"debug","time":"2024-07-04T21:50:07-03:00","message":"unable to reach "console.kubefirst.dev/api/proxyHealth" (15/60)"}

You didn't reach the k3s stage with this error. There is a problem with your k3d installer.

I attach the my logs with multiples test to analyze.

Seems like this is a certificate issue, see https://docs.kubefirst.io/k3d/quick-start/install#install-the-ca-certificate-authority-of-mkcert-in-your-trusted-store . I don't think you needed to do that for the installer, just for k3d. What OS are you trying this from?

If you need to test something, tell me... I've the local environment prepared.

For now it's good, I should be able to give it a test later today 🤞, so until I do my test, don't take more time trying yours, unless you really want to.

fharper · 2024-07-09T13:53:58Z

So I was able to test this PR again today. The SSH issue I had is fixed with the API PR as we thought, thanks Drummy!

I wasn't completely successful though.

The CLI step after "Initializing Vault" is empty. It may be related to the second point though.

I got stuck at this step as there is an error in the logs: it's looking for a AWS key. I assume it's an issue as one shouldn't need AWS in this process at all, unless I'm mistaken?

At any point, the CLI should exit with an error if there is an issue, and it cannot continue. The process is going strong after a while, even if now it's just displaying the 500 error in loop.

In any cases, right now, the #1 & #3 could be fixed by us at some point, but #2 is more a question for you @DrummyFloyd . As soon as I can, I'll give a try also with GitLab to see if it's specific to this PR or if I can reproduce everywhere with k3s.

DrummyFloyd · 2024-07-09T14:24:46Z

ok good, we're going forward =D ( i ported the fix to Gitlab to in this PR fyi)

like i said , in the first comment, of the PR, i wasn't really sure about TF stuff, so maybe, it come from there,

yes please try upon GITLAB , to check if you have the same issue

quite hard to check everything on all theses template + Tf stuff ^^

EDIT: @fharper i pushed few fix

fharper · 2024-07-09T20:30:34Z

I didn't have time to test with GitLab, but testing with the latest fix on this PR + GitHub now.

Any ideas why you have none of the issues I get when I test!?

For GitLab, my plan was to test with the latest release, am I correct? Or should I use this PR since you added a fix here also? Just to be sure.

Unrelated, I was struggling to create the VMs before being able to test (unrelated to K3s, something based on my machine configurations), so from now on, I' gonna be able to test way faster.

DrummyFloyd · 2024-07-09T20:39:07Z

I didn't have time to test with GitLab, but testing with the latest fix on this PR + GitHub now.

Any ideas why you have none of the issues I get when I test!?

because i did not test the entire mechanism ^^'

For GitLab, my plan was to test with the latest release, am I correct? Or should I use this PR since you added a fix here also? Just to be sure.

you have to use the template from this PR f0a738b

fharper · 2024-07-09T20:45:10Z

So at the Vault configuration (or right after), something weird happened with GitHub. It tried to access a cluster on DigitalOcean (and really tried as Little Snitch asked me to accept or not a connection to digitalocean.com). I assumed it's some copy/paste somewhere?

fharper · 2024-07-09T21:37:04Z

I just tested GitLab and it reached mostly the end. I'm stuck at the "Wrapping up" step. The last log entries are "waiting for final sync wave Deployment to transition to Running" and "waiting for crossplane Deployment to be created" . The only thing I can see in the cluster is GitLab runner pods still running with errors in their logs (see screenshot).

I can access the Vault interface, but not Argo CD nor the management (console). They all give me this error.

DrummyFloyd · 2024-07-09T21:47:14Z

So at the Vault configuration (or right after), something weird happened with GitHub. It tried to access a cluster on DigitalOcean (and really tried as Little Snitch asked me to accept or not a connection to digitalocean.com). I assumed it's some copy/paste somewhere?

because some tf stuff was a copy/paste from DO template, i may have missed some Do_token will check taht

DrummyFloyd · 2024-07-09T21:48:06Z

I just tested GitLab and it reached mostly the end. I'm stuck at the "Wrapping up" step. The last log entries are "waiting for final sync wave Deployment to transition to Running" and "waiting for crossplane Deployment to be created" . The only thing I can see in the cluster is GitLab runner pods still running with errors in their logs (see screenshot).

I can access the Vault interface, but not Argo CD nor the management (console). They all give me this error.

at this point, i think something change on kubefirst/kubefrist-api because @jarededwards fixed that before the K3S-gitlab was merge with everything =)

EDIT:
or i could be a GITLAB change from how token are provded (if i remember well , they change abreaking change upon SaaS) dunno how the compatibility is on this TF + gitlab runner registration

https://docs.gitlab.com/runner/install/kubernetes.html#required-configuration

=s

=> including that breaking change all of your GITLAB tempalte are break =/ actual version (at least in europe 17.2)

fharper · 2024-07-10T15:57:51Z

I doubt it's a GitLab issue, as in, how GitLab works, the product, not how we use it, since GitLab is working on other clouds.

As for GitHub, I'll give it another test hopefully today.

fharper · 2024-07-10T16:10:47Z

So the GitLab issue may be related to https://github.com/kubefirst/gitops-template/pull/771/files

DrummyFloyd · 2024-07-10T16:14:20Z

So the GitLab issue may be related to https://github.com/kubefirst/gitops-template/pull/771/files

is totallyy that ^^, will rebase my PR to get these changes =)

fharper · 2024-07-10T18:12:39Z

I'm trying GitHub now.

fharper · 2024-07-10T18:55:53Z

So I ended up with nearly the same state for GitHub than GitLab. It's stuck at the "wrapping up" step, and the last log entry is waiting on crossplane deployment.

Here the state of the pods

I'll wait on this GitHub fix to test GitLab again, as I assume the token issue was fixed for GitLab Runner, but I may end up at the same place.

fharper · 2024-07-16T20:39:41Z

We are soooo close!

So I tried GitHub and it worked on first try: I moved passed my crossplane issue.

I tried GitLab, but ended up with a new issue (see screenshot). I will give it a second try, but I wonder if it's not one of the latest changes when we removed GitLab stuff.

fharper

We have an issue with Atlantis + Metaphor on GitLab, but since K3s is still in beta, and that this PR was about GitHub, we are finally good to merge and release this 🎉

Thanks a lot @DrummyFloyd & everyone who helped!

DrummyFloyd force-pushed the add-k3s-github branch from 17b5dc3 to cf893ee Compare May 21, 2024 00:13

DrummyFloyd mentioned this pull request May 21, 2024

K3s provisioning konstructio/kubefirst#1748

Closed

6 tasks

fharper assigned DrummyFloyd May 21, 2024

fharper added the enhancement New feature or request label May 21, 2024

DrummyFloyd force-pushed the add-k3s-github branch from 0c191f3 to f0a738b Compare July 4, 2024 00:43

DrummyFloyd mentioned this pull request Jul 4, 2024

fix: pass SSH private key content as environment variable for K3s konstructio/kubefirst-api#353

Merged

DrummyFloyd added 8 commits July 10, 2024 18:15

feat(k3s): add github manifests templates

a9166ce

feat(k3s): github tf

4ad6ce5

feat(k3s): users tf

6c5ca12

feat(k3s): vault tf

f23fffd

fix(k3s): typo tfvars

7e6d5b7

fix(k3s): pass ssh key content as var

8a819e6

fix: missing vault:variables tf

a822842

fix: relics from DO templates cahnge to k3s

62168c8

DrummyFloyd force-pushed the add-k3s-github branch from eb231ab to 62168c8 Compare July 10, 2024 16:15

DrummyFloyd and others added 2 commits July 16, 2024 01:03

fix(k3s): remove not used tf required providers

b9670ef

fixes external secret ref for github

b3a52e1

add crossplane secret to terraform

0eeac33

fharper approved these changes Jul 17, 2024

View reviewed changes

fharper merged commit 80c820f into konstructio:main Jul 17, 2024
1 check passed

BrewTestBot mentioned this pull request Jul 18, 2024

kubefirst 2.4.13 Homebrew/homebrew-core#177753

Merged

Add k3s GitHub #758

Add k3s GitHub #758

Conversation

DrummyFloyd commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024

fharper commented May 21, 2024

fharper commented May 23, 2024

DrummyFloyd commented May 23, 2024 • edited Loading

fharper commented May 30, 2024

DrummyFloyd commented May 30, 2024 • edited Loading

fharper commented May 30, 2024

DrummyFloyd commented May 30, 2024 • edited Loading

maxiar commented Jun 24, 2024

DrummyFloyd commented Jun 24, 2024 • edited Loading

fharper commented Jun 25, 2024

maxiar commented Jun 26, 2024

fharper commented Jun 26, 2024

fharper commented Jun 26, 2024

DrummyFloyd commented Jun 26, 2024 • edited Loading

DrummyFloyd commented Jun 30, 2024

maxiar commented Jul 2, 2024

fharper commented Jul 2, 2024

maxiar commented Jul 2, 2024

DrummyFloyd commented Jul 4, 2024

fharper commented Jul 4, 2024

maxiar commented Jul 4, 2024 • edited Loading

fharper commented Jul 4, 2024

DrummyFloyd commented Jul 4, 2024 • edited by fharper Loading

fharper commented Jul 8, 2024

fharper commented Jul 9, 2024

DrummyFloyd commented Jul 9, 2024 • edited Loading

fharper commented Jul 9, 2024

DrummyFloyd commented Jul 9, 2024 • edited Loading

fharper commented Jul 9, 2024

fharper commented Jul 9, 2024

DrummyFloyd commented Jul 9, 2024

DrummyFloyd commented Jul 9, 2024 • edited Loading

fharper commented Jul 10, 2024

fharper commented Jul 10, 2024

DrummyFloyd commented Jul 10, 2024 • edited Loading

fharper commented Jul 10, 2024

fharper commented Jul 10, 2024

fharper commented Jul 16, 2024

fharper left a comment

Choose a reason for hiding this comment

DrummyFloyd commented May 21, 2024 •

edited

Loading

DrummyFloyd commented May 23, 2024 •

edited

Loading

DrummyFloyd commented May 30, 2024 •

edited

Loading

DrummyFloyd commented May 30, 2024 •

edited

Loading

DrummyFloyd commented Jun 24, 2024 •

edited

Loading

DrummyFloyd commented Jun 26, 2024 •

edited

Loading

maxiar commented Jul 4, 2024 •

edited

Loading

DrummyFloyd commented Jul 4, 2024 •

edited by fharper

Loading

DrummyFloyd commented Jul 9, 2024 •

edited

Loading

DrummyFloyd commented Jul 9, 2024 •

edited

Loading

DrummyFloyd commented Jul 9, 2024 •

edited

Loading

DrummyFloyd commented Jul 10, 2024 •

edited

Loading