Fixes #832 do not add definitions for excluded methods #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases the method will be excluded from the swagger (because it misses httpMethod or Api annotation), but the return type of the method is added to the definitions as parseMethod() had side effect and modified the swagger.model object. Removed the side effect of parseMethod().
|
@kongchen Is there any change this to be merged soon? We need it as it block the upgrade to newer swagger-maven-plugin. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the method will be excluded from the swagger (because it
misses httpMethod or Api annotation), but the return type of the method
is added to the definitions as parseMethod() had side effect and
modified the swagger.model object.
Removed the side effect of parseMethod().