-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KONFLUX-4892): supply layer size information to pyxis #634
Open
ralphbean
wants to merge
7
commits into
development
Choose a base branch
from
pyxis-layer-sizes
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphbean
force-pushed
the
pyxis-layer-sizes
branch
7 times, most recently
from
October 22, 2024 23:43
e255e74
to
4e95304
Compare
I think this is ready for review now (aside from the obvious wrong |
ralphbean
commented
Oct 22, 2024
mmalina
reviewed
Oct 23, 2024
johnbieren
reviewed
Oct 24, 2024
ralphbean
force-pushed
the
pyxis-layer-sizes
branch
3 times, most recently
from
October 24, 2024 22:55
abbc6db
to
9b854aa
Compare
ralphbean
force-pushed
the
pyxis-layer-sizes
branch
from
October 24, 2024 22:59
9b854aa
to
dd588c7
Compare
mmalina
reviewed
Oct 25, 2024
mmalina
reviewed
Oct 25, 2024
This is meant to be paired with a change in the step image: konflux-ci/release-service-utils#284 If the layers of the image are found to be gzip compressed, then pull them, decompress them, and include information about their decompressed digests and sizes in the manifest provided to the pyxis script. Signed-off-by: Ralph Bean <[email protected]>
Signed-off-by: Ralph Bean <[email protected]>
Signed-off-by: Ralph Bean <[email protected]>
This pulls in the following change: konflux-ci/release-service-utils#284 Signed-off-by: Ralph Bean <[email protected]>
Signed-off-by: Ralph Bean <[email protected]>
Signed-off-by: Ralph Bean <[email protected]>
ralphbean
force-pushed
the
pyxis-layer-sizes
branch
from
October 25, 2024 20:08
b40f121
to
cf61a01
Compare
Signed-off-by: Ralph Bean <[email protected]>
@ralphbean: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-hdj49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be paired with a change in the step image: konflux-ci/release-service-utils#284
If the layers of the image are found to be gzip compressed, then pull them, decompress them, and include information about their decompressed digests and sizes in the manifest provided to the pyxis script.
Normal images will always have the layers compressed. If they are not compressed, this will not save the uncompressed data in Pyxis.