Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sources table rendering #6140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prushh
Copy link
Contributor

@prushh prushh commented Oct 16, 2024

Fixes #6139

Proposed Changes

  • add missing table delimiters (pipes)
  • update RedisSource url with knative-extensions/eventing-redis repository url

Copy link

knative-prow bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prushh
Once this PR has been reviewed and has the lgtm label, please assign pierdipi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2024
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 31bb109
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/670fcfb5de24330008cb0337
😎 Deploy Preview https://deploy-preview-6140--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prushh
Copy link
Contributor Author

prushh commented Oct 16, 2024

Should I bump the RedisSource status to "Beta"?
Ref: https://github.com/knative-extensions/eventing-redis?tab=readme-ov-file#redis-components-for-knative

Edit: Also let me know if I can fix the unit tests in this PR, I think it is only necessary to change the version of express in the Recreating the sample code section of this README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knative Sources table is not rendered properly in browser
1 participant