Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPDS name mapper #830

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

OPDS name mapper #830

wants to merge 16 commits into from

Commits on Oct 18, 2022

  1. [New] Use a macro to define catalog's entries in test.

    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    cc849b3 View commit details
    Browse the repository at this point in the history

  2. Make the opds_dumper respect the provided nameMapper used in the server. 

    Fix #828
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    96fb423 View commit details
    Browse the repository at this point in the history

  3. fixup! Make the opds_dumper respect the provided nameMapper used in t… 

    …he server.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    24472e0 View commit details
    Browse the repository at this point in the history

  4. Introduce a ServerConfiguration object. 

    It is used to store the server configuration instead of passing (a lot of)
arguments to functions/creators.

Please note that this remove the thread protected on m_verbose.
m_verbose is initialized once and never modified, be don't need to protect
access.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    85f58b8 View commit details
    Browse the repository at this point in the history

  5. fixup! Introduce a ServerConfiguration object. 

    Move from `ServerConfiguration` to `Server::Configuration`.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    5896691 View commit details
    Browse the repository at this point in the history

  6. Do not store raw pointer to Library. 

    While it was "ok" to store raw pointer as, in our use case, the library
always live longer than object using it; it is not safe to store
raw pointer on object than may be deleted.

All classes storing a library now store a shared_ptr.
Functionr only using the library (as `HumanReadableNameMapper`) continue
to use a (const) reference.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    0bd5a5e View commit details
    Browse the repository at this point in the history

  7. fixup! Do not store raw pointer to Library.

    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    4842fa0 View commit details
    Browse the repository at this point in the history

  8. Do not store raw pointer to NameMapper. 

    While it was "ok" to store raw pointer as, in our use case, the nameMapper
always live longer than object using it; it is not safe to store
raw pointer on object than may be deleted.

All classes storing a NameMapper now store a shared_ptr.
Functions only using the library (as `HumanReadableNameMapper`) continue
to use a (const) reference.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    3d75f24 View commit details
    Browse the repository at this point in the history

  9. Make internalServer use m_root from configuration instead of using it… 

    …s own.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    92c0e14 View commit details
    Browse the repository at this point in the history

  10. Make InternalServer use the NameMapper of the configuration. 

    This move the defaulting to IdNameMapper in the configuration instead of
in the InternalServer.

This also create a default shared_ptr per Configuration instead of
using a static default one.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    422e71a View commit details
    Browse the repository at this point in the history

  11. [NEW] Make InternalServer inherite Server::Configuration. 

    This avoid a lot of silly `m_configuration.foo`.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    3e54e56 View commit details
    Browse the repository at this point in the history

  12. Make the OPDSDumper use the ServerConfiguration.

    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    6815a4c View commit details
    Browse the repository at this point in the history

  13. Make fullEntryXML use the configuration to get the bookName.

    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    37ccfb5 View commit details
    Browse the repository at this point in the history

  14. Change the default NameMappe to use a HumanReadableNameMapper

    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    7d83127 View commit details
    Browse the repository at this point in the history

  15. Add a Server::isRunning to know if the server is running or not.

    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    1fcc2ad View commit details
    Browse the repository at this point in the history

  16. Make kiwix::Server a simple wrapper around kiwix::InternalServer. 

    `kiwix::Server` is now a simple exposition of a public API on top of the
private `InternalServer`.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    d112470 View commit details
    Browse the repository at this point in the history