A couple of bugfixes in Download management #1024
Conversation
So far the details of the host serving the OPDS catalog were hardcoded. In order to debug issues related to large downloads it helps if one can use one's own server. Hence this enhancement.
The static function RowNode::createNode() was moved into ContentManagerModel as is.
Download update timers are no-longer managed separately in ContentManagerModel. Instead the timer associated with each active download is owned by the respective RowNode object.
Now DownloadState is an optional element of the state of RowNode and is set in it only in case of an active (even if paused) download associated with the that entry.
This is needed for preserving download state across filtering and similar operations that currently work by fully rebuilding the ContentManagerModel.
This fixes the bugs related to pending download statuses being discarded by filtering and similar operations that result in full update of the ContentManagerModel. Instead this commit leads to a new bug - completion of a download is not always properly detected for very small (and thus instantaneous) downloads. This is caused by library update events triggered by ZIM directory monitoring (which notifies about a new ZIM file appearing in the download directory) interfering with the download status update signal.
It's more logical to check for the conditions of a disappeared download first.
This fix is rather a temporary and ugly hack, since the current mess with how download states are being maintained (in the presence of multiple sources of their updates) asks for a major clean-up.
The diff is simpler if whitespace changes are ignored.
|
Nice changes !
I strongly agree. I would go even further. I think we could probably drop the whole At the time, The library view was implemented in html/js and it was discussing with the c++ part through a |
Fixes #1021
Fixes #1023
This PR also contains some attempts at cleaning up the code, however the conclusion is that a major overhaul is required.
Overall it looks like there are many more bugs related to Download management, and the proper way to eliminate them all is to significantly simplify the code architecture through a more direct usage of
Kiwix::Download.