Awaited send message #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to send a message over an awaited server socket (i.e. when you need external servers to reply to your listening server socket) the sock.sendto call needs to also be awaited. This commit adds async/await versions of the send_message and send_bundle functions that are called by the OSCCurioServer and OSCTrioServer send_message methods.
In order to send a message over an awaited server socket (i.e. when you need external servers to reply to your listening server socket) the sock.sendto call needs to also be awaited. This commit adds async/await versions of the send_message and send_bundle functions that are called by the OSCCurioServer and OSCTrioServer send_message and send_bundle methods.
… awaited-send_message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add awaited send_message functions for curio and trio implementations
In order to send a message over an awaited server socket (i.e. when you need external servers to reply to your listening server socket) the sock.sendto call needs to be awaited as well.
This commit adds async/await versions of the send_message and send_bundle functions that are called by the OSCCurioServer and OSCTrioServer send_message and send_bundle methods.
Strictly speaking, the async/await functions would probably not be used directly from the client module, so maybe there is a better place to put them. I tried to find ways to reduce code duplication as much as possible.