Fix/50/win oserror #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshirtman
force-pushed
the
fix/50/win_oserror
branch
2 times, most recently
from
61de898
to
cc18083
Compare
tshirtman
force-pushed
the
fix/50/win_oserror
branch
from
121cf48
to
badd856
Compare
|
I encountered some "struct.error" too in the _listen() loop / read_packet(), when a client sent too big message (>65535 bytes) to the server; wouldn't it be better to catch and log ANY error, since there are lots of things that can go wrong when reading buggy packets ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.