Catalog config importer #5313
Merged
Catalog config importer #5313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
solth
force-pushed
the
import-config-importer
branch
from
0205da0
to
08ebea0
Compare
solth
force-pushed
the
import-config-importer
branch
3 times, most recently
from
ae5fc3d
to
7b33e1e
Compare
markusweigelt
suggested changes
Sep 30, 2022
Kitodo/src/main/java/org/kitodo/production/forms/createprocess/CatalogImportDialog.java
Outdated
Show resolved
Hide resolved
| // Find mapping file object by filename | ||
| for (MappingFile currentFile : allMappingFiles) { | ||
| if (currentFile.getFile().equals(filename)) { | ||
| mappingFile = currentFile; |
There was a problem hiding this comment.
Can be reduced when name of item variable is directly so designated.
Kitodo/src/main/java/org/kitodo/production/helper/CatalogConfigurationImporter.java
Outdated
Show resolved
Hide resolved
|
Import works well except for the description which is not imported. Otherwise, the imported catalogs seem to have all the search fields and settings as in the XML. In general, I think it would be great to have a general documentation with a hint to migrate the XML or to extend or adapt the existing one. In perspective the documentation should be updated in a PR. But for that we first need a useful and complete user documentation. :-/ |
markusweigelt
approved these changes
Oct 4, 2022
solth
force-pushed
the
import-config-importer
branch
from
ba44972
to
b7d3d11
Compare
solth
force-pushed
the
import-config-importer
branch
from
4d99d8b
to
7e498d8
Compare
markusweigelt
approved these changes
Oct 6, 2022
This was referenced Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an catalog configuration importer that transforms opac configurations from existing
kitodo_opac.xmlfiles into newImportConfigurationobjects. Also creates correspondingMappingFileobjects where needed.Fixes #5224
Fixes #5262
Edit: this PR should be merged after #5293!