Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mandatory metadata required #4949

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

IkramMaalej
Copy link
Collaborator

Part of #4322
Fixes #4377
Fixes #3403

@andre-hohmann
Copy link
Collaborator

@IkramMaalej : It seems as there is still no check for lists with checkboxes, of which at least one must be selected. In my tests, it is the list of "Digital Collections". See example below.
I can create a process without selecting a digital collection, but when i validate the process in the metadata editor, i get a warning, that no digital collection is selected.

I cannot assess the behaviour with drop-down-fields, because in these mandatory fields (script, rights information, ...), one value has to be chosen. It is not possible to select an "empty" value. This might be described in:

Other mandatory text-fields, as for example TSL/ATS, CatalogIDDigital, ... are validated correctly.

Example

validationdigitalcollection

@andre-hohmann
Copy link
Collaborator

@IkramMaalej:
The validation works now. Processes cannot be created, when mandatory checkbox lists are not selected.

However, there are error messages, which cannot be interpreted - see example below. Either, the text of the messages must be adjusted, or the messages must be hidden.

In my opinion, the error messages can be hidden, because of the two following arguments:

  1. There are no error messages, when mandatory text fields are empty.
  2. The affected fields are highlighted by red lines and can be identified.

Auswahl_Kollektion

@Kathrin-Huber Kathrin-Huber merged commit 9b58e21 into kitodo:master Mar 17, 2022
@IkramMaalej IkramMaalej deleted the mandatory-metadata branch April 5, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants