Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use batch type to find newspaper batches #4421

Conversation

matthias-ronge
Copy link
Collaborator

@matthias-ronge matthias-ronge commented May 19, 2021

As @henning-gerhardt suggested in #4417 (comment), the batch type should be used to determine whether a batch is a newspaper batch.

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could "test" your changes only on my local system and not on our migration system (local data vs data on and over network): your changes looks good and the displaying of this newspaper migration site is now fast.

@matthias-ronge matthias-ronge force-pushed the detect-newspaper_batches_by_batch_type branch from d2fcbd5 to 37b080f Compare May 26, 2021 10:14
@matthias-ronge
Copy link
Collaborator Author

That pleases me! I hope @Kathrin-Huber will then take up these changes in a timely manner ...

@Kathrin-Huber Kathrin-Huber merged commit 3cb8499 into kitodo:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants