Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI crashes when loading ruleset fails #4131

Closed
matthias-ronge opened this issue Jan 5, 2021 · 0 comments · Fixed by #4133
Closed

UI crashes when loading ruleset fails #4131

matthias-ronge opened this issue Jan 5, 2021 · 0 comments · Fixed by #4133
Labels

Comments

@matthias-ronge
Copy link
Collaborator

Screenshot of crash

java.lang.NullPointerException
    at org.kitodo.production.forms.createprocess.CreateProcessForm.getAllRulesetDivisions(CreateProcessForm.java:113)
    at org.kitodo.production.forms.createprocess.CreateProcessForm.updateRulesetAndDocType(CreateProcessForm.java:100)
    at org.kitodo.production.forms.createprocess.CreateProcessForm.prepareProcess(CreateProcessForm.java:356)

The reason is that if an error occurs while reading the ruleset, the exception is caught and the object remains uninitialized. Then an attempt is made to access the object. In addition, only the exception message is logged, without a stack trace, so that the error cannot be traced:

[ERROR] 2021-01-05 09:57:49.133 [http-nio-8080-exec-7] CreateProcessForm - null

Furthermore, the code is named unsystematically at the point. The ruleset management is sometimes referred to as the ruleset and sometimes as the ruleset management interface. The names should be standardized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant