Skip to content

Commit

Permalink
Apply David's suggestions, and a couple of more improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
sneridagh committed Oct 25, 2024
1 parent dbf0655 commit 7eea356
Show file tree
Hide file tree
Showing 14 changed files with 19 additions and 84 deletions.
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
"stylelint": "stylelint 'packages/**/src/**/*.{css,scss,less}' --allow-empty-input",
"stylelint:fix": "stylelint 'packages/**/src/**/*.{css,scss,less}' --fix --allow-empty-input",
"dry-release": "release-it --dry-run",
"release": "pnpm --filter @kitconcept/volto-button-block release",
"release-major-alpha": "pnpm --filter @kitconcept/volto-button-block release-major-alpha",
"release-alpha": "pnpm --filter @kitconcept/volto-button-block release-alpha",
"release": "pnpm --filter @kitconcept/volto-separator-block release",
"release-major-alpha": "pnpm --filter @kitconcept/volto-separator-block release-major-alpha",
"release-alpha": "pnpm --filter @kitconcept/volto-separator-block release-alpha",
"storybook": "pnpm build:deps && VOLTOCONFIG=$(pwd)/volto.config.js pnpm --filter @plone/volto storybook dev -p 6006 -c $(pwd)/.storybook",
"build-storybook": "pnpm build:deps && VOLTOCONFIG=$(pwd)/volto.config.js pnpm --filter @plone/volto build-storybook -c $(pwd)/.storybook"
},
Expand All @@ -41,4 +41,4 @@
"mrs-developer": "^2.2.0"
},
"packageManager": "[email protected]"
}
}
14 changes: 12 additions & 2 deletions packages/volto-separator-block/.gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
node_modules
.*project
.settings/
.vscode
*~
acceptance/cypress/videos/
acceptance/node_modules
.storybook-build
build
README.md
core
node_modules
results
yarn.lock
/public
9 changes: 3 additions & 6 deletions packages/volto-separator-block/src/components/Data.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { BlockDataForm } from '@plone/volto/components';
import { SeparatorSchema } from './schema';

const SeparatorData = (props) => {
const { data, block, onChangeBlock, schemaEnhancer, navRoot, contentType } =
const { data, block, blocksErrors, onChangeBlock, schemaEnhancer, ...rest } =
props;
const intl = useIntl();
const schema = schemaEnhancer
Expand All @@ -21,12 +21,9 @@ const SeparatorData = (props) => {
[id]: value,
});
}}
onChangeBlock={onChangeBlock}
formData={data}
fieldIndex={data.index}
block={block}
navRoot={navRoot}
contentType={contentType}
errors={blocksErrors}
{...rest}
/>
);
};
Expand Down
4 changes: 0 additions & 4 deletions packages/volto-separator-block/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ const applyConfig = (config) => {
restricted: false,
mostUsed: true,
sidebarTab: 1,
security: {
addPermission: [],
view: [],
},
enableStyling: false,
};

Expand Down
Binary file removed public/android-chrome-192x192.png
Binary file not shown.
Binary file removed public/android-chrome-512x512.png
Binary file not shown.
Binary file removed public/apple-touch-icon.png
Binary file not shown.
Binary file removed public/favicon-16x16.png
Binary file not shown.
Binary file removed public/favicon-32x32.png
Binary file not shown.
Binary file removed public/favicon.ico
Binary file not shown.
13 changes: 0 additions & 13 deletions public/icon.svg

This file was deleted.

34 changes: 0 additions & 34 deletions public/index.html.spa

This file was deleted.

2 changes: 0 additions & 2 deletions public/robots.txt

This file was deleted.

19 changes: 0 additions & 19 deletions public/site.webmanifest

This file was deleted.

0 comments on commit 7eea356

Please sign in to comment.