document that BASE_ROUTE_PATH requires the prefix to be stripped #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Thanks for the PR (: I like the idea, but I might just fix it at the source and strip prefixes when I'm parsing the base route so people don't have to think about it. I'm going to be out of cell service for the next week so I'll come back to this on Monday! |
|
That'd be a great fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
N/A
What's changed?
Tiny change to the readme to make the reverse proxy config easier to figure out. I had to dig into past PRs and found it in the discussion of #275 to figure it out.
What's fixed?
N/A
Any other comments?
N/A