Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement client-only layout. #195

Merged
merged 8 commits into from
Nov 8, 2024
Merged

implement client-only layout. #195

merged 8 commits into from
Nov 8, 2024

Conversation

NiklasRentzCAU
Copy link
Member

Hardcode to use it for now, switch between modes missing yet.

@NiklasRentzCAU NiklasRentzCAU added enhancement New feature or request klighd-core requires server change This change is linked to some change on the server side implementation in KLighD hackathon A ticket that could be solved in a hackthon labels Sep 28, 2024
Eddykasp
Eddykasp reviewed Sep 28, 2024
View reviewed changes
Copy link
Contributor

@Eddykasp Eddykasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should import all of elks algorithms not just layered

@NiklasRentzCAU
Copy link
Member Author

Before merging, this PR needs to include a way to switch between server and client layout, with the default being server layout for now.
For further improvement, this PR could also include a new message part in the "capabilities" messaging that asks the server if it supports server layout (to which the Java server would reply true) and automatically adapt its setting to the supported one (client layout if the server does not support it, server layout otherwise)

@Eddykasp
Copy link
Contributor

Eddykasp commented Oct 9, 2024 •
edited
Loading

  • add json schema for our lsp messages
  • mark correct fields in schema as required
  • add validification using the new json schemas

@NiklasRentzCAU
Copy link
Member Author

Closes #139

Eddykasp
Eddykasp reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Eddykasp Eddykasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still missing the change to make the debug option switch no longer a debug option

Eddykasp
Eddykasp approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Eddykasp Eddykasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Nov 8, 2024
Open
Open
@NiklasRentzCAU NiklasRentzCAU marked this pull request as ready for review November 8, 2024 14:58
@NiklasRentzCAU NiklasRentzCAU merged commit 7e029f3 into main Nov 8, 2024
1 check passed
@NiklasRentzCAU NiklasRentzCAU deleted the nre/client-only-layout-new branch November 8, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddykasp Eddykasp Eddykasp approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hackathon A ticket that could be solved in a hackthon klighd-core requires server change This change is linked to some change on the server side implementation in KLighD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiklasRentzCAU @Eddykasp