Allow KImages to refer to arbitrary URIs, which will be linked in the SVG #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first implementation to include images in the SVG outside of the bundled language server jar in the diagram. URIs available to the application can be used with this, e.g. URLs to images found online.
To refer to a URI image, add a KImage to the model with
bundleName = "URI"and the URI in theimagePathattribute.This implementation just refers to those images, a different implementation also enabling to refer to e.g. image files next to the visualized model will be worth expanding on this feature, as well as downloading and embedding the images in the SVG instead of linking to them for better compatibility during SVG export.