Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not override label text on unmodified labels #217

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

NiklasRentzCAU
Copy link
Member

instead, only on modified ones.

The label management also has the MANAGED_UNMODIFIED result, which should also not cause the label to be overwritten by the (unmodified) result. Only the MANAGED_MODIFIED should overwrite the label's text and tooltip.

@NiklasRentzCAU NiklasRentzCAU added the bug Something isn't working label Oct 14, 2024
@NiklasRentzCAU NiklasRentzCAU self-assigned this Oct 14, 2024
Copy link
Contributor

@Eddykasp Eddykasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm I guess

@NiklasRentzCAU NiklasRentzCAU merged commit fa9c8c9 into master Oct 14, 2024
3 checks passed
@NiklasRentzCAU NiklasRentzCAU deleted the nre/labels-text-override-only-managed branch October 14, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants