Remove unused imports in Java and xtend classes #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run the 'Organize imports' action on each class that has unused imports.
HannesWell
force-pushed
the
remove-unused-imports
branch
from
a68cc2e
to
02c6a83
Compare
NiklasRentzCAU
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Our ordering is as suggested by you, just by applying the auto-organize from Eclipse. Some of these files however were auto-generated by Xtext (version 2.10 according to the sources) and therefore might change back when re-generating. But as we have not re-generated these files for a long time and do not plan to, and because Xtext had a lot of updates since then, I will just approve these changes as well for reducing the amount of warnings. Thank you!
NiklasRentzCAU
added
the
cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the 'Organize imports' action on each class that has unused imports.
On some classes the re-order also existing and used imports. Do you have specific settings for the order of import statements (e.g. in Eclipse preferences: Java -> Code Style -> Organize Imports)? I just used the default settings for this. Please let me know if I should change them.