lsp: remove outermost padding to remove border when exporting SVGs. #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasRentzCAU
added
enhancement
|
I don't see a reason why one would want to always pad the 12 pixels on exported graphs, and why it should be exactly 12. So I would not want to add an option for this. |
|
Fixes kieler/klighd-vscode#18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually when exporting the graph with Sprotty, we just export the entire graph as-is. ELK has a default value for its padding of 12 pixels, which is also applied to the outermost invisible graph node, shifting all elements inwards by these 12 pixels.
This fix avoids that issue by removing the outermost padding before the layout on any graph, as that would be invisible anyways. With this, exported graphs will always be snug around the outermost graph elements.
Fixes kieler/klighd-vscode#46.