klighd.piccolo: important change in the drawing coordinate system application, solves #56 #104
Conversation
There was a problem hiding this comment.
Solves a definitely interesting problem and looks good in the code. I just tested it with the one application where I use some special zoom technique (OsgiViz with zoom to stay) and there the result was always a little off what is expected by zoom to stay, i.e. the focused element did not stay at the same relative position in the viewport and always shifted to some other position when some clipping is used. So this does not break anything but does also not fix the problem for this use case yet.
…lication, solves #56 * now the local transform of the (main) diagram's clip node is *not* applied anymore if the diagram is clipped, while (for non-clipped diagrams) the transform of the diagram's root KNodeTopNode is supposed to be the identity under all circumstances; * updated related code portions concerning the zooming, the clipping functionality, the outline, and the magnifier lens
|
The change has been accepted by the customer. If other changes in the affected code regions are required, this PR should be merged beforehand, of course. |
hey guys,
for solving #56 I had to do a quite massive change, essential change is this:
ebbe39b#diff-084c1ba8ab1f3979a86885fe58fde7d8c723cbad0fd28be303ad083236b2967aL624-R670
Everything else is basically corresponding adjustment to keep everything in sync and working.