Skip to content

Commit

Permalink
klighd: "Fixed" broken ChildArea Placement
Browse files Browse the repository at this point in the history
See f613c17
This line was removed thinking it was not needed in #165, but in fact it
was needed. Reverting this to its working previous state.
  • Loading branch information
NiklasRentzCAU committed Aug 1, 2023
1 parent cce3484 commit 80cb658
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,10 @@ private void createNode(final LayoutMapping mapping, final KNode node,

// KLighD is somewhat mean and doesn't care about existing insets
node.setInsets(insets);
// This line should not be needed as it just sets the default paddings if none existed yet, and every use of
// this property needs to "get" it first, theoretically resulting in always setting the default values.
// But this still seems to be necessary to fix child area placement. See also f613c1758bdc05c4461e4a2cc47dee0cb8556416
node.getProperty(CoreOptions.PADDING);
// The Insets are used in {@link KlighdLayoutConfigurationStore} to retrieve the padding
// of the node

Expand Down

0 comments on commit 80cb658

Please sign in to comment.