Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main branch with Apache main branch #32

Merged
merged 4 commits into from
Apr 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .ci/jenkins/Jenkinsfile.build-image
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ pipeline {
// Debug purpose in case of issue
sh 'cat tests/test-apps/clone-repo.sh'
sh 'cat scripts/setup-maven.sh'
sh 'cat tests/features/kogito-s2i-builder.feature'
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

- [ ] You have read the [contributors guide](README.md#contributing-to-kogito-images-repository)
- [ ] Pull Request title is properly formatted: `[KOGITO|RHPAM-XYZ] Subject`
- [ ] Pull Request title is properly formatted: `[Issue XXXX] Subject`
- [ ] Pull Request contains link to the JIRA issue
- [ ] Pull Request contains description of the issue
- [ ] Pull Request does not include fixes for issues other than the main ticket
Expand Down
23 changes: 14 additions & 9 deletions .github/workflows/kogito-images-pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Install xmllint
run: |
sudo apt-get update
sudo apt-get install libxml2-utils --fix-missing
sudo apt-get update &&\
sudo apt-get -y install --no-install-recommends --fix-missing \
libxml2-utils
- name: Cache bats binaries
uses: actions/cache@v1
with:
Expand All @@ -25,22 +26,22 @@ jobs:
- name: run bats
run: |
./scripts/run-bats.sh

validate_kogito_imagestream:
concurrency:
group: ${{ github.repository.name }}_validate_kogito_imagestream-${{ github.head_ref }}
cancel-in-progress: true
name: Validate Kogito imagestreams
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Download openshift-validator-tool
run: |
wget https://github.com/jboss-container-images/jboss-kie-modules/raw/main/tools/openshift-template-validator/openshift-template-validator-linux-amd64
- name: Add execution permission to openshift-validator-tool
run: |
chmod +x openshift-template-validator-linux-amd64
mv openshift-template-validator-linux-amd64 ${HOME}
mv openshift-template-validator-linux-amd64 ${HOME}
- name: validate kogito imagestream
run: |
${HOME}/openshift-template-validator-linux-amd64 validate -f kogito-imagestream.yaml
Expand All @@ -53,11 +54,15 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Install Shellcheck
run: sudo apt install shellcheck
run: |
sudo apt-get update &&\
sudo apt-get -y install --no-install-recommends \
shellcheck
- name: Check configure scripts
run: |
# Ignore SC2034 since we have many var which are unused in the script but can be used while deployment at runtime by setting env. For eg: ${KOGITO_QUARKUS_JVM_PROPS}
# Ignore SC1090 since the source files in our case didn't need to be checked
shellcheck -e SC2034 -e SC1090 modules/**/configure modules/**/*.sh
shopt -s globstar nullglob
shellcheck -e SC2034 -e SC1090 -S warning modules/**/configure modules/**/*.sh
Loading
Loading