Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Sample Concept #683

Merged
merged 6 commits into from
May 30, 2024
Merged

✨ Add Sample Concept #683

merged 6 commits into from
May 30, 2024

Commits on May 30, 2024

  1. ✨ Modify biospecimen_group to ingest into sample in kf

    @chris-s-friedman
    chris-s-friedman committed May 30, 2024
    Configuration menu
    Copy the full SHA
    1106a14 View commit details
    Browse the repository at this point in the history

  2. ✨ Allow connecting biospecimen to sample

    @chris-s-friedman
    chris-s-friedman committed May 30, 2024
    Configuration menu
    Copy the full SHA
    0ad1e1f View commit details
    Browse the repository at this point in the history

  3. ✨ Actually ingest sample

    @chris-s-friedman
    chris-s-friedman committed May 30, 2024
    Configuration menu
    Copy the full SHA
    d6126f6 View commit details
    Browse the repository at this point in the history

  4. ♻️ Make sample its own concept and allow sample or biospecimen 

    🚨 Don't mess up formmatting

🚨 Don't mess up formmatting

point to sample when building sample key concept

🐛 Add submit function to sample
    @chris-s-friedman
    chris-s-friedman committed May 30, 2024
    Configuration menu
    Copy the full SHA
    d5bbddf View commit details
    Browse the repository at this point in the history

  5. 📝 Document samples and specimens 

    🚧 Working on documentation for samples and biospecimens

📝 Document samples and specimens

🔥 Remove test text

🚨 Enable black linting

📝 re-word docs for better clarity

Co-authored-by: Natasha Singh <[email protected]>

Update docs/source/design/concepts/samples_and_specimens.rst

Co-authored-by: Natasha Singh <[email protected]>

Update docs/source/design/concepts/samples_and_specimens.rst

Co-authored-by: Natasha Singh <[email protected]>

Update docs/source/design/concepts/samples_and_specimens.rst

Co-authored-by: Natasha Singh <[email protected]>

Update docs/source/design/concepts/samples_and_specimens.rst

Co-authored-by: Natasha Singh <[email protected]>

Update docs/source/design/concepts/samples_and_specimens.rst

Co-authored-by: Natasha Singh <[email protected]>

Update docs/source/design/concepts/index.rst

Co-authored-by: Natasha Singh <[email protected]>

🚨 Keep docs under 80 character line length

🚨 Documentation line length
    @chris-s-friedman
    chris-s-friedman committed May 30, 2024
    Configuration menu
    Copy the full SHA
    a956f02 View commit details
    Browse the repository at this point in the history

  6. 📝 Document why biospecimen group is still around

    @chris-s-friedman
    chris-s-friedman committed May 30, 2024
    Configuration menu
    Copy the full SHA
    3206940 View commit details
    Browse the repository at this point in the history