🐛 Dont assume sample_id exists, since fk is optional on BS

kids-first · Jun 4, 2024 · cf58921 · cf58921
1 parent ff6c83f
commit cf58921
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/kf_lib_data_ingest/target_api_plugins/kids_first_dataservice.py b/kf_lib_data_ingest/target_api_plugins/kids_first_dataservice.py
@@ -589,6 +589,12 @@ def query_target_ids(cls, host, key_components):
 
     @classmethod
     def build_entity(cls, record, get_target_id_from_record):
+        # sample foreign key is optional
+        try:
+            sample_id = get_target_id_from_record(Sample, record)
+        except Exception:
+            sample_id = None
+
         secondary_components = {
             "kf_id": get_target_id_from_record(cls, record),
             "sequencing_center_id": record.get(
@@ -677,7 +683,7 @@ def build_entity(cls, record, get_target_id_from_record):
                 CONCEPT.BIOSPECIMEN.DBGAP_STYLE_CONSENT_CODE
             ),
             "consent_type": record.get(CONCEPT.BIOSPECIMEN.CONSENT_SHORT_NAME),
-            "sample_id": get_target_id_from_record(Sample, record),
+            "sample_id": sample_id,
         }
         return {
             **cls.get_key_components(record, get_target_id_from_record),