Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix hard filter #14

Merged
merged 6 commits into from
May 20, 2024
Merged

🐛 fix hard filter #14

merged 6 commits into from
May 20, 2024

Conversation

migbro
Copy link
Collaborator

@migbro migbro commented May 17, 2024

Description

A recent update in attempting to harden bcftools filer step with a pipefail caused the include expression to fail in somatic workflow. This was missed during testing since the somatic workflow was not pointing to this update. I have refactored the tool, removing the pipe of include-to-exclude functionality as it is never used and is more trouble that it's worth.

Fixes # BIXU-3657

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@migbro migbro added bug Something isn't working bix-dev labels May 17, 2024
@migbro migbro self-assigned this May 17, 2024
Copy link
Collaborator

@dmiller15 dmiller15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ugly but functional. I'm dubious about the loss of the pipefail most of all since we still have a piped scenario here.

tools/bcftools_filter_vcf.cwl Show resolved Hide resolved
tools/bcftools_filter_vcf.cwl Outdated Show resolved Hide resolved
@migbro migbro merged commit f777ca0 into master May 20, 2024
1 check passed
@migbro migbro deleted the bug/mb-fix-hard-filter branch May 20, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants