Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mc tutorial suggestions #689

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Conversation

nrfox
Copy link
Contributor

@nrfox nrfox commented Aug 22, 2023

Follow up from review suggestions. Mostly just adds a bit more info about the multicluster environment and tweaks some sentences here and there. My editor also applied some autolinting.

Also fixes some links that were causing build failures to get CI passing again.

@nrfox nrfox self-assigned this Aug 22, 2023
Copy link
Contributor

@leandroberetta leandroberetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nick, these changes looks fine. Thanks for the review.

@leandroberetta leandroberetta merged commit e30ba9b into kiali:staging Aug 23, 2023
5 checks passed
hhovsepy pushed a commit to hhovsepy/kiali.io that referenced this pull request Apr 5, 2024
* Add more info about env to MC tutorial

* Remove also

* Further tweaks

* Attempt to fix links

* More link fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants