-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove role 1.89 and add role 2.1 from default #839
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the two changes to the default yaml files (see earlier comments), this looks OK. But I want to run the molecule tests on this before I approve. I will get that done in the next day or so
I'm running this against my CRC (I first made those two changes I suggested above, then I did "make cluster-push" both in kiali and OSSMC repos so I get the dev images pushed):
Will report back the results when done. I don't expect anything to fail here, but we'll see. |
Co-authored-by: John Mazzitelli <[email protected]>
with these two changes: diff --git a/playbooks/kiali-default-supported-images.yml b/playbooks/kiali-default-supported-images.yml
index ea0f562..0d593ea 100644
--- a/playbooks/kiali-default-supported-images.yml
+++ b/playbooks/kiali-default-supported-images.yml
@@ -2,4 +2,4 @@ default: {"image_name": "quay.io/kiali/kiali", "image_version": "operator_versio
v1.57: {"image_name": "quay.io/kiali/kiali", "image_version": "v1.57"}
v1.65: {"image_name": "quay.io/kiali/kiali", "image_version": "v1.65"}
v1.73: {"image_name": "quay.io/kiali/kiali", "image_version": "v1.73"}
-v1.89: {"image_name": "quay.io/kiali/kiali", "image_version": "v2.1"}
+v2.1: {"image_name": "quay.io/kiali/kiali", "image_version": "v2.1"}
diff --git a/playbooks/ossmconsole-default-supported-images.yml b/playbooks/ossmconsole-default-supported-images.yml
index ec7e586..46da701 100644
--- a/playbooks/ossmconsole-default-supported-images.yml
+++ b/playbooks/ossmconsole-default-supported-images.yml
@@ -1,3 +1,3 @@
default: {"imageName": "quay.io/kiali/ossmconsole", "imageVersion": "operator_version"}
-v1.89: {"imageName": "quay.io/kiali/ossmconsole", "imageVersion": "v2.1"}
+v2.1: {"imageName": "quay.io/kiali/ossmconsole", "imageVersion": "v2.1"}
v1.73: {"imageName": "quay.io/kiali/ossmconsole", "imageVersion": "v1.73"} the molecule tests pass:
|
Co-authored-by: John Mazzitelli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is required for next TP2 after release 2.1